-
Notifications
You must be signed in to change notification settings - Fork 56
Packaging: Set productArchitecture
#941
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we not be passing that across the other MSIs as well?
It seems to be only used by that one target but I don't know if msbuild and/or wix also use that property internally. |
ebf5ecd
to
d3c7607
Compare
productArchitecture
in Package jobproductArchitecture
Actually I was wrong, I updated the PR. Here's the new try job: https://github.com/thebrowsercompany/swift-build/actions/runs/14577741095 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The smoke test failed, but the packaging succeeded. I think that this is a good step forward.
This updates the packaging steps following swiftlang/swift-installer-scripts#413 This cherry-picks the following PRs: * GHA: shuffle the Foundation headers #918 * GHA: shuffle more files for Dispatch, Foundation #935 * Create directory before moving items #936 * GHA: adjust the installer build phases #937 * GHA: enable _Builtin_float on android #942 * Installer: Properly include Android platform #944 * Update Android root folder #943 * Packaging: Set productArchitecture #941 * Android: Update Android platform packaging #940
This updates the packaging steps following swiftlang/swift-installer-scripts#413 This cherry-picks the following PRs: * GHA: shuffle the Foundation headers #918 * GHA: shuffle more files for Dispatch, Foundation #935 * Create directory before moving items #936 * GHA: adjust the installer build phases #937 * GHA: enable _Builtin_float on android #942 * Installer: Properly include Android platform #944 * Update Android root folder #943 * Packaging: Set productArchitecture #941 * Android: Update Android platform packaging #940 Co-authored-by: Saleem Abdulrasool <[email protected]>
This fixes the Windows Arm64 build job.