Skip to content

test-setup-build: Properly escape quotes #970

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 31, 2025
Merged

test-setup-build: Properly escape quotes #970

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions .github/workflows/test-setup-build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ jobs:
Write-Output "::error::Expected build tools version `"${env:TEST_BUILD_TOOLS_EXPECTED_VERSION}`", but got `"${BuildToolsVersion}`"."
$HasError = $true
} else {
Write-Output "✅ Build tools version `${BuildToolsVersion}` matches expected version."
Write-Output "✅ Build tools version `"${BuildToolsVersion}`" matches expected version."
}

# Check if the correct MSVC version is installed.
Expand All @@ -92,7 +92,7 @@ jobs:
$InstallPath = (& "$VSWhere" -latest -products * -format json | ConvertFrom-Json).installationPath
$MSVCDir = Join-Path $InstallPath "VC" "Tools" "MSVC" $BuildToolsVersion
if (Test-Path -Path $MSVCDir) {
Write-Output "✅ MSVC version `${env:TEST_MSVC_VERSION}`" is installed."
Write-Output "✅ MSVC version `"${env:TEST_MSVC_VERSION}`" is installed."
} else {
Write-Output "::error::MSVC directory not found: `"${MSVCDir}`"."
$HasError = $true
Expand Down Expand Up @@ -189,7 +189,7 @@ jobs:
Write-Output "::error::Expected build tools version `"${env:TEST_BUILD_TOOLS_EXPECTED_VERSION}`", but got `"${BuildToolsVersion}`"."
$HasError = $true
} else {
Write-Output "✅ Build tools version `${BuildToolsVersion}` matches expected version."
Write-Output "✅ Build tools version `"${BuildToolsVersion}`" matches expected version."
}

# Check if the correct MSVC version is installed.
Expand All @@ -198,7 +198,7 @@ jobs:
$InstallPath = (& "$VSWhere" -latest -products * -format json | ConvertFrom-Json).installationPath
$MSVCDir = Join-Path $InstallPath "VC" "Tools" "MSVC" $BuildToolsVersion
if (Test-Path -Path $MSVCDir) {
Write-Output "✅ MSVC version `${env:TEST_MSVC_VERSION}`" is installed."
Write-Output "✅ MSVC version `"${env:TEST_MSVC_VERSION}`" is installed."
} else {
Write-Output "::error::MSVC directory not found: `"${MSVCDir}`"."
$HasError = $true
Expand Down
Loading