unit testing improvement #51

peter279k · 2017-01-11T16:47:39Z

Change log

Improve the unit testing and code coverage.
the travis-ci status is available here.
the code coverage report is available here.
Fix the error in .php_cs.
In PHP-CS-Fixer version 2.0.0, removing some configurations because they are not available. And fix the class not found error. (please see this issue).

codecov-io · 2017-01-11T16:54:57Z

Current coverage is 97.17% (diff: 100%)

No coverage report found for master at 69407bb.

Powered by Codecov. Last update 69407bb...808ec2b

stof · 2017-01-11T18:08:05Z

if codecov-io adds a comment each time the PR is updated, this is a no-go IMO. It is spammy.

stof · 2017-01-11T18:08:43Z

.travis.yml

@@ -1,7 +1,5 @@
 language: php

-sudo: false


should be reverted

Hi @stof, the original configuration is false.
Please see this PR. Thanks.

the default value for sudo is not always false actually. It depends on repositories.

Ok, I have been confused this for a long time.
Would you please provide some references about this?
Thanks!

It's false for this repo by default though.

See https://blog.travis-ci.com/2016-04-07-migration-update and https://docs.travis-ci.com/user/ci-environment/#Virtualization-environments

@alcohol but it makes it harder to copy-paste the config elsewhere (composer has some repository where it is not the default)

Hi all, I think the proper way is adding the sudo: false for each time so that it can always make sure that it's running on the non-root environment.

What do you think?

Thanks.

yeah, I prefer being explicit too, as it does not require knowing at which date the repo started using Travis (this info is not available anywhere except in the Travis database AFAIK, and we cannot access it)

stof · 2017-01-11T18:09:04Z

.travis.yml

@@ -20,10 +18,14 @@ php:

 matrix:
  fast_finish: true
+  allow_failures:
+    - php: hhvm


why ? it is passing in master, so there is no reason to allow it to fail. If your changes are breaking things, you should fix your contribution instead

The HHVM is failed because it doesn't support the ReflectionClass.
I use this feature because I want to test some methods directly.

Hi @stof, thank you for your suggestions again.
Now the HHVM is fixed and remove the allow_failures.
Thanks.

stof · 2017-01-11T18:12:45Z

tests/Constraint/AbstractConstraintTest.php

+    {
+        $expectedString = 'pretty string';
+        $constraint = new \ReflectionClass('\Composer\Semver\Constraint\AbstractConstraint');
+        $setPrettyString = $constraint->getMethod('setPrettyString');


it would be much better to test this through the public API instead

As I know, the AbstractConstraintTest is deprecated abstract class so I just use the ReflectionClass to test the trigger_error.

As they are public method, you should just create a child class extending the abstract class and use the public API if you want to cover these methods.

Thank you for your tips.
Fix it.

stof · 2017-01-11T18:19:11Z

tests/Constraint/EmptyConstraintTest.php

+    protected function tearDown()
+    {
+        unset($this->versionProvide);
+        unset($this->emptyConstraint);


you should not unset the class properties. You should only reset their values (or do nothing as there is no circular dependency with the TestCase, so the refcounting will work fine)

You're right. I will fix it later.

peter279k · 2017-01-11T18:42:46Z

Hi @stof. Thank you for your comment, I just want to show the code coverage report so I add the codecov-io service. The owner can remove this and it's up to them. The PR is updated each time that I think it's not a important problem.

stof · 2017-01-11T18:49:30Z

@peter279k each time there is a comment, maintainers receive an email. Gettings lots of emails just because the service reports the coverage status (which will only change in minor ways) is just spam IMO. github has better ways for automated systems to report an info for the PR (the status API)

peter279k · 2017-01-11T19:02:01Z

Hi @stof, you're right. This should have the spam mail problem.
I think it should show one time and it doesn't show this after the up-coming commit.

stof · 2017-01-12T10:41:34Z

.travis.yml

  - composer install --no-interaction --no-progress --prefer-dist

 script:
-  - vendor/bin/phpunit
+  - vendor/bin/phpunit -d error_reporting=16384


add -d option for hhvm

Guess it is related to hhvm?

Yes. Please refer this issue.

Thanks.

Seldaek · 2017-01-22T18:28:22Z

I think it'd be great to have the new tests in a separate PR as that is clearly an improvement.. The code coverage stuff though I am not so sure. I am not a fan of such metrics as they tend to incentivize the wrong things if they're displayed too prominently. Code coverage is a tool and that's available to anyone willing to improve the test suite by locally enabling it when running phpunit

peter279k · 2017-01-25T02:05:55Z

Hi @Seldaek. You're right and I also am not the fan of code metric.
On the other hand, the code coverage is important because doing testing is to find bugs.
If the code coverage is higher, it possibly finds bugs, too.
This is IMO and I hope you can refer it.

Thanks.

GrahamCampbell · 2020-01-14T11:16:53Z

What's the status here. This should probably go through first, before I (or anyone else) looks to finish #74.

Seldaek · 2020-01-14T11:38:30Z

I'll merge the tests and skip the rest.. You can work on #74 based on that assumption if it helps.

GrahamCampbell · 2020-01-14T11:54:21Z

I'll look at that PR next week (hopefully!). :)

peter279k added 2 commits January 12, 2017 00:16

unit testing improvement

cc36d51

.php_cs fix psr2 syntax(and using fixer 2.0)

808ec2b

stof reviewed Jan 11, 2017

View reviewed changes

peter279k added 6 commits January 12, 2017 03:16

remove unset class properties

6de4ba4

extend abstract class and testing

e4117d2

add __toString method (implement)

4c84154

fix the hhvm problem about PHPUnit exception

48550d5

add -d option for hhvm

ce5854e

remove allow_failures option

2c00546

stof reviewed Jan 12, 2017

View reviewed changes

Seldaek merged commit 2c00546 into composer:master Jan 14, 2020

Uh oh!

unit testing improvement #51

unit testing improvement #51

Uh oh!

Conversation

peter279k commented Jan 11, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Change log

Uh oh!

codecov-io commented Jan 11, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Current coverage is 97.17% (diff: 100%)

Uh oh!

stof commented Jan 11, 2017

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

peter279k Jan 11, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

peter279k Jan 12, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

peter279k Jan 12, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

peter279k commented Jan 11, 2017

Uh oh!

stof commented Jan 11, 2017

Uh oh!

peter279k commented Jan 11, 2017

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Seldaek commented Jan 22, 2017

Uh oh!

peter279k commented Jan 25, 2017

Uh oh!

GrahamCampbell commented Jan 14, 2020

Uh oh!

Seldaek commented Jan 14, 2020

Uh oh!

GrahamCampbell commented Jan 14, 2020

Uh oh!

Uh oh!

peter279k commented Jan 11, 2017 •

edited

Loading

codecov-io commented Jan 11, 2017 •

edited

Loading

peter279k Jan 11, 2017 •

edited

Loading

peter279k Jan 12, 2017 •

edited

Loading

peter279k Jan 12, 2017 •

edited

Loading