Skip to content

Update package.yaml #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 15, 2017
Merged

Update package.yaml #17

merged 1 commit into from
Aug 15, 2017

Conversation

phadej
Copy link
Contributor

@phadej phadej commented Aug 14, 2017

hpack doesn't seem to validate valid names. . worked by accident as current Cabal-file parser is too lax.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 99.838% when pulling e3b1fd0 on phadej:patch-1 into abec3b4 on harendra-kumar:master.

@harendra-kumar
Copy link
Member

@phadej Thanks! I was not sure about this when I added it but I was in a hurry. How did you find this out? Is there something that depends on this change?

The stack nightly seems to be failing but it is not due to this change, that test needs to be added back to allow_failures in .travis.yml I guess.

@harendra-kumar
Copy link
Member

Please add the generated unicode-transforms.cabal as well to the commit.

@phadej
Copy link
Contributor Author

phadej commented Aug 14, 2017

Travis breakage is fixed in commercialhaskell/stack#3349

I found the other-modules issue while working on the new parser for Cabal.

@coveralls
Copy link

coveralls commented Aug 14, 2017

Coverage Status

Coverage remained the same at 99.838% when pulling a373b09 on phadej:patch-1 into abec3b4 on harendra-kumar:master.

@harendra-kumar harendra-kumar merged commit fb240fe into composewell:master Aug 15, 2017
@harendra-kumar
Copy link
Member

Thanks for the PR!

@phadej phadej deleted the patch-1 branch August 15, 2017 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants