Skip to content

skip emsdk from kb-h016 #348

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Oct 1, 2021
Merged

Conversation

uilianries
Copy link
Member

Signed-off-by: Uilian Ries <[email protected]>
jgsogo
jgsogo previously approved these changes Sep 30, 2021
@uilianries uilianries closed this Sep 30, 2021
@uilianries uilianries reopened this Sep 30, 2021
@SSE4 SSE4 requested a review from danimtb October 1, 2021 06:24
SSE4
SSE4 previously approved these changes Oct 1, 2021
@SSE4
Copy link
Contributor

SSE4 commented Oct 1, 2021

@uilianries CI is not happy :(

@jgsogo
Copy link
Contributor

jgsogo commented Oct 1, 2021

Why this is not taking into account the changes from master? It should be using the right pylint version.

@uilianries
Copy link
Member Author

Good morning fellas, yes, it seems related to pylint version.

@jgsogo
Copy link
Contributor

jgsogo commented Oct 1, 2021

but this one (already merged) should have been fixed it: #349. The problem is that this PR is not using the requirements that are listed in the file 🤷

@uilianries
Copy link
Member Author

@jgsogo we should use --no-cache-dir, otherwise pip will be prefer its cache, just like Conan.

Signed-off-by: Uilian Ries <[email protected]>
@uilianries uilianries dismissed stale reviews from SSE4 and jgsogo via a028a06 October 1, 2021 11:22
@jgsogo
Copy link
Contributor

jgsogo commented Oct 1, 2021

@jgsogo we should use --no-cache-dir, otherwise pip will be prefer its cache, just like Conan.

but if the file says pylint==2.10.2 it should use any cache and decide that 2.11.0 is better 😄

Signed-off-by: Uilian Ries <[email protected]>
Copy link
Contributor

@jgsogo jgsogo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Finally, it was just a lazy CI 😄

@jgsogo jgsogo merged commit ded8949 into conan-io:master Oct 1, 2021
@uilianries
Copy link
Member Author

It's Friday, the CI wants a break!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants