Skip to content

add some optional deps to build #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 17, 2018
Merged

Conversation

wholmgren
Copy link
Member

@wholmgren wholmgren commented Sep 15, 2018

Checklist

  • Used a fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Re-rendered with the latest conda-smithy
  • Ensured the license file is being packaged.

The pvlib-python license file is not currently packaged in the PyPI releases. Opened pvlib/pvlib-python#579 to resolve for the next release. This PR is for a new build of 0.5.2, so we'll have to skip the license for now.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@wholmgren
Copy link
Member Author

@conda-forge-admin, please rerender

@wholmgren
Copy link
Member Author

@mikofski would you like to see scipy/pytables/numba/pyephem bundled with the conda package? I'm skipping netcdf/siphon for now because I can't figure out how to include a package from pypi in the build.

@mikofski
Copy link
Member

mikofski commented Sep 16, 2018

IMO yes include everything in the conda build, or release more than one version, eg "lite" and "complete". Not sure how to include siphon and netCDF4 without vendorizing them. I think in the build script you could use skeleton but seems like a lot of work. Maybe add to docs install instructions to manually install them. I think Unidata has a conda channel, maybe try that?

@wholmgren
Copy link
Member Author

I agree that including everything would be ideal, but it's not worth the effort to me. Just to clarify... do you agree that it's better to include these packages in the conda package than none at all? We're not changing the default source/pypi installation, so there would be an inconsistency there too.

@mikofski
Copy link
Member

Sorry, I don't really have a strong opinion either way. I just thought it would be easier, from a user perspective if everything was just installed

@wholmgren
Copy link
Member Author

wholmgren commented Sep 17, 2018 via email

@wholmgren wholmgren merged commit 02d5be4 into conda-forge:master Sep 17, 2018
@wholmgren wholmgren deleted the optdeps branch September 17, 2018 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants