-
Notifications
You must be signed in to change notification settings - Fork 6
KC-1270: Seed MetadataCache w/ the active controller ID on MetaLogManager listener callback #464
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…th new leader info - Integrate w/ the BrokerMetadataListener/MetadataCache for the broker to be notified through RAFT - Remove active controller ID from the heartbeat response
This reverts commit 82fff44.
- Configure broker/controller to use a common `metadata.log.dir` - Fix metadata checkpoints discovery to include the `metadata.log.dir` - Minor fix in `BrokerToControllerChannelManager` to use the correct controller for ManualMetadataUpdate in the NetworkClient
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One concurrency issue, but I outlined a quick solution. If you go with it probably best to leave copious comments about why the code is always taking the latest controller ID instead of writing what it got when it copied the metadata cache state.
core/src/main/scala/kafka/server/metadata/BrokerMetadataListener.scala
Outdated
Show resolved
Hide resolved
PartitionMetadata
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Committer Checklist (excluded from commit message)