Skip to content

KC-1270: Seed MetadataCache w/ the active controller ID on MetaLogManager listener callback #464

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 22 commits into from
Dec 10, 2020

Conversation

aloknnikhil
Copy link

Committer Checklist (excluded from commit message)

  • Verify design and implementation
  • Verify test coverage and CI build status
  • Verify documentation (including upgrade notes)

…th new leader info

- Integrate w/ the BrokerMetadataListener/MetadataCache for the broker
to be notified through RAFT
- Remove active controller ID from the heartbeat response
This reverts commit 82fff44.
- Configure broker/controller to use a common `metadata.log.dir`
- Fix metadata checkpoints discovery to include the `metadata.log.dir`
- Minor fix in `BrokerToControllerChannelManager` to use the correct
controller for ManualMetadataUpdate in the NetworkClient
@aloknnikhil aloknnikhil requested a review from cmccabe December 9, 2020 23:39
Copy link

@rondagostino rondagostino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One concurrency issue, but I outlined a quick solution. If you go with it probably best to leave copious comments about why the code is always taking the latest controller ID instead of writing what it got when it copied the metadata cache state.

Copy link

@rondagostino rondagostino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aloknnikhil aloknnikhil merged commit deef7a6 into confluentinc:kip-500 Dec 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants