Skip to content

Conversation

GunalKupta
Copy link
Contributor

@GunalKupta GunalKupta commented Mar 28, 2025

What

Checklist

  • Contains customer facing changes? Including API/behavior changes
  • Is this change gated behind feature flag(s)?
    • List the LD flags needed to be set to enable this change
  • Did you add sufficient unit test and/or integration test coverage for this PR?
    • If not, please explain why it is not required
    • No code change
  • Does this change require modifying existing system tests or adding new system tests?
    • If so, include tracking information for the system test changes

References

JIRA: DGS-20118

Test & Review

Ran bin/schema-registry-start config/schema-registry.properties locally and verified that the logs look identical when run in this branch and master branch

Open questions / Follow-ups

@Copilot Copilot AI review requested due to automatic review settings March 28, 2025 00:14
@GunalKupta GunalKupta requested a review from a team as a code owner March 28, 2025 00:14
@confluent-cla-assistant
Copy link

🎉 All Contributor License Agreements have been signed. Ready to merge.
Please push an empty commit if you would like to re-run the checks to verify CLA status for all contributors.

Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request upgrades the code to use log4j2 while updating protobuf generated code accordingly. In addition, the changes update method calls and builder types in the WidgetProto and WidgetProto2 classes, and clarify doc comments in Decimal message types.

  • Replaces calls to GeneratedMessageV3 with GeneratedMessage.
  • Updates usage of SingleFieldBuilderV3 to SingleFieldBuilder.
  • Enhances documentation by clarifying the semantics of the precision field in Decimal types.

Reviewed Changes

Copilot reviewed 8 out of 22 changed files in this pull request and generated no comments.

File Description
schema-rules/src/test/java/io/confluent/kafka/schemaregistry/rules/WidgetProto2.java Updates method calls for string writing and changes builder type; removes overrides for unknown field handling.
schema-rules/src/test/java/io/confluent/kafka/schemaregistry/rules/WidgetProto.java Switches method calls and builder types similarly, and removes unknown field override methods.
protobuf-types/src/main/java/io/confluent/protobuf/type/DecimalOrBuilder.java Improves the comment describing the precision field.
protobuf-types/src/main/java/io/confluent/protobuf/type/Decimal.java Updates the doc comments for precision in several locations.
Files not reviewed (14)
  • avro-serializer/src/test/resources/log4j.properties: Language not supported
  • avro-serializer/src/test/resources/log4j2.xml: Language not supported
  • benchmark/src/main/resources/log4j.properties: Language not supported
  • benchmark/src/main/resources/log4j2.xml: Language not supported
  • config/log4j.properties: Language not supported
  • config/log4j2.xml: Language not supported
  • core/src/main/resources/log4j.properties: Language not supported
  • core/src/main/resources/log4j2.xml: Language not supported
  • core/src/test/resources/log4j.properties: Language not supported
  • core/src/test/resources/log4j2.xml: Language not supported
  • protobuf-converter/src/test/resources/log4j.properties: Language not supported
  • protobuf-converter/src/test/resources/log4j2.xml: Language not supported
  • schema-rules/src/test/resources/log4j.properties: Language not supported
  • schema-rules/src/test/resources/log4j2.xml: Language not supported
Comments suppressed due to low confidence (2)

schema-rules/src/test/java/io/confluent/kafka/schemaregistry/rules/WidgetProto2.java:3318

  • The removal of the overridden setUnknownFields and mergeUnknownFields methods may affect unknown fields handling. Please verify that this change does not introduce regressions in message parsing behavior.
      @java.lang.Override

schema-rules/src/test/java/io/confluent/kafka/schemaregistry/rules/WidgetProto.java:3015

  • The removal of the overridden setUnknownFields and mergeUnknownFields methods could impact the handling of unknown fields. Confirm that this change is intentional and does not compromise message consistency.
      @java.lang.Override

@sonarqube-confluent

This comment has been minimized.

@sonarqube-confluent

This comment has been minimized.

3 similar comments
@sonarqube-confluent

This comment has been minimized.

@sonarqube-confluent

This comment has been minimized.

@sonarqube-confluent

This comment has been minimized.

Copy link
Member

@rayokota rayokota left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a minor comment

@sonarqube-confluent

This comment has been minimized.

@sonarqube-confluent

This comment has been minimized.

@GunalKupta GunalKupta requested a review from rayokota March 28, 2025 20:53
@sonarqube-confluent
Copy link

Passed

Analysis Details

0 Issues

  • Bug 0 Bugs
  • Vulnerability 0 Vulnerabilities
  • Code Smell 0 Code Smells

Coverage and Duplications

  • Coverage No coverage information (74.00% Estimated after merge)
  • Duplications No duplication information (2.10% Estimated after merge)

Project ID: schema-registry

View in SonarQube

Copy link
Member

@rayokota rayokota left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @GunalKupta , LGTM

@GunalKupta GunalKupta merged commit 7bd70a9 into master Mar 28, 2025
3 of 6 checks passed
@GunalKupta GunalKupta deleted the dgs-20118 branch March 28, 2025 20:58
@GunalKupta GunalKupta mentioned this pull request Apr 3, 2025
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants