-
Notifications
You must be signed in to change notification settings - Fork 2
Add doc about gRPC (lack of) compatibility and migration path #20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Anuraag Agrawal <[email protected]>
@@ -0,0 +1,98 @@ | |||
# gRPC compatibility |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Put some thought into whether this is actually the right title when there isn't compatibility, but it seemed still fine but open to any thoughts
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, just a nit about casing
docs/grpc-compatibility.md
Outdated
Connect-Python currently does not support the gRPC protocol due to lack of support for HTTP/2 trailers | ||
in the Python ecosystem. If you have an existing codebase using grpc-python and want to introduce Connect | ||
in a transition without downtime, you will need a way for the gRPC servers to be accessible from both | ||
gRPC and Connect clients at the same time. envoy is a widely used proxy server with support for translating |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: I see "envoy" stylized both all lowercase and capitalized on https://www.envoyproxy.io/docs/envoy/latest/; I think I'd opt for caps here?
gRPC and Connect clients at the same time. envoy is a widely used proxy server with support for translating | |
gRPC and Connect clients at the same time. Envoy is a widely used proxy server with support for translating |
Looking a little more, although the logomark is lowercase, the rest of the docs seem to refer to it as Envoy (and so do the Connect docs). So I might just s/envoy/Envoy
throughout this doc?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks - yeah eyes landed on the only two instances of lowercase in those docs for some reason
Signed-off-by: Anuraag Agrawal <[email protected]>
Signed-off-by: Anuraag Agrawal <[email protected]>
No description provided.