Skip to content

Support deriving CLike #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

LunaBorowska
Copy link

Fixes #22. The custom derive code is based on enum-map crate.

Some notes:

  • It's possible to make enum-set re-export derive macro provided by enum-set-derive, but it is a bit hacky.
  • This needs to be a separate crate due to how procedural derive macros work.
  • It's possible to remove 32 variants limit, however it likely involves backward compatibility break.

@FlashCat
Copy link
Contributor

Thanks for the pull request, and welcome! The contain-rs team is excited to review your changes, and you should hear from @reem (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. The way Github handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

@bowbahdoe
Copy link

bowbahdoe commented Jan 20, 2020

Any updates on this PR? I don't think this will require a separate crate anymore

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Derive CLike (e.g. via custom_derive)
4 participants