GetNodeIDErrorCode needs help

[jdef]

#21 adds GetNodeIDError to the possibilities of an Error.value, but the codes defined by GetNodeIDErrorCode don't actually seem to apply to GetNodeID -- copy/paste error?

[akutz]

Hi @jdef,

This is blocking my work as I cannot respond to a GetNodeID request with an appropriate error.

[akutz]

Also, this has been outstanding for 27 days. May I recommend you bring some additional people onto the project to take a more active role in reviewing and fixing issues? I volunteer :)

[akutz]

FWIW I've resolved it locally with my csi.mk file. The relevant sections are lines 137-138 and 153-154:

	    -e 's@\(ProbeNodeError probe_node_error = 9;$$\)@\1\
    GetNodeIDError get_node_id_error = 10;@g' >> $@

[jdef]

Thanks for the bump, I'll prioritize this

…

On Wed, Jun 28, 2017 at 1:06 PM, Schley Andrew Kutz < ***@***.***> wrote: FWIW I've resolved it locally with my csi.mk file <https://gist.github.com/akutz/2b0126749b00b53294314557310aae52#file-csi-mk>. The relevant section is lines 140-152 <https://gist.github.com/akutz/2b0126749b00b53294314557310aae52#file-csi-mk-L140-L152> : $(CSI_PROTO): @mkdir -p ***@***.***) ref=$$(git ls-remote $(CSI_GIT_URI) $(CSI_GIT_REF) | awk '{print $$1}') && \ ref="$${ref:-$(CSI_GIT_REF)}" && \ printf "$(CSI_PRINTF_FMT)" \ "$(CSI_GIT_OWNER)/$(CSI_GIT_REPO):$${ref}" \ "$(CSI_IMPORT_PATH)" \ "$(CSI_IMPORT_PATH)" > $@ && \ curl -sSL $(CSI_SPEC_URI) | \ sed -n -e '/```protobuf$$/,/```$$/ p' | \ sed -e 's@^```.*$$@***@***.***' \ -e 's@\(ProbeNodeError probe_node_error = 9;$$\)@\1\ GetNodeIDError get_node_id_error = ***@***.***' >> $@ — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#31 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ACPVLIx9ecMjn0kg4FS3u7PlmHAk8VLVks5sIogNgaJpZM4NtFpz> .

[jdef]

@akutz PR #21 has landed, hopefully this unblocks you

[jdef]

pretty sure that #115 resolved this. if not, please re-open