Version the CSI package name #194
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch fixes issue container-storage-interface#193 and adds changes the CSI package name from `csi` to `csi.vMAJOR(MINOR)?` where `MINOR` is added if `MAJOR` is `0`. For example: v0.2.0 -> csi.v02 v2.1.0 -> csi.v2 The leading zero and subsequent `MINOR` component is necessary to prevent collision with the eventual `v1.0`, `v2.0`, etc. releases.
akutz
changed the title
|
Please note that this affects all languages, not just Go, since the protobuf type names now include the version. For example, |
|
Replaced by #195. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch fixes issue #193 and adds changes the CSI package name from
csitocsi.vMAJOR(MINOR)?whereMINORis added ifMAJORis0. For example:v0.2.0csi.v02v2.1.0csi.v2The leading zero and subsequent
MINORcomponent is necessary to prevent collision with the eventual releasesv1.0,v2.0, etc.Accessing Older Spec and Language Binding Files
Please note this patch does not address accessing older versions of the specification. The generated files such as
csi.protoandlib/go/csi/csi.pb.goare not in versioned paths or have versioned file names. This is on purpose. Maintaining all previous versions at theHEADof the repository would result in a convoluted generation process as well as questions about whetherlib/go/csi/v2isv2.0,v2.1.5,v2.3, etc.People that wish to access older versions of the specification can do so by using
gitor GitHub's UI to fetch a specific tag or commit and manually copying the protobuf or language binding locally.At least that's my thought on the matter. I elected to keep it simple (for now).