Bump release to 5.4.0 #510
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: inknos The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/packit test |
|
@jwhonce PTAL we see the infinite job flake again but the tests are passing |
inknos
force-pushed
the
5.4.0
branch
9 times, most recently
from
f63eff2 to
c1e5e69
Compare
Signed-off-by: Nicola Sella <[email protected]>
|
LGTM |
There was a problem hiding this comment.
just as general feedback as you have asked for a review, I cannot follow any of the changes besides the obvious version number changes.
I at least would think the github action fix and tmt change must in a separate commit and explain why these are changes are made in the commit message. Like this I have no idea why they are needed, there is no link to an issue, etc... And if someone goes back later and git blame points we at something like that I would have nothing to go by why this was done.
Now I do so that the indentation in the github action but simply saying this int he commit message goes a long way for a reviewer like me.
Anyway I am not a maintainer here so merge if you like.
|
LGTM |
|
/lgtm |
No description provided.