update tests duo to CRUN#1767 to support both values #26760
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci
bot
added
the
do-not-merge/release-note-label-needed
Luap99
reviewed
Aug 6, 2025
openshift-ci
bot
added
the
do-not-merge/work-in-progress
timcoding1988
force-pushed
the
feat/RUN-3333_fixing-cpu-weight-test
branch
2 times, most recently
from
ec7f353 to
4ab918f
Compare
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
timcoding1988
force-pushed
the
feat/RUN-3333_fixing-cpu-weight-test
branch
3 times, most recently
from
c444d24 to
e26283f
Compare
openshift-ci
bot
added
the
do-not-merge/work-in-progress
timcoding1988
force-pushed
the
feat/RUN-3333_fixing-cpu-weight-test
branch
4 times, most recently
from
d95d6ab to
3f30af9
Compare
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
timcoding1988
force-pushed
the
feat/RUN-3333_fixing-cpu-weight-test
branch
2 times, most recently
from
aed54b2 to
a4b4748
Compare
openshift-ci
bot
added
the
do-not-merge/work-in-progress
timcoding1988
force-pushed
the
feat/RUN-3333_fixing-cpu-weight-test
branch
2 times, most recently
from
434d03f to
1de27d8
Compare
Luap99
reviewed
Aug 13, 2025
There was a problem hiding this comment.
If you like to make a test run with the new crun to make sure both version pass please use the image id c20250812t173301z-f42f41d13 containers/automation_images#411 (comment). In fact if that passes CI we can just merge it with the image bump.
|
Oh and it seems your commit has the wrong author set, |
timcoding1988
force-pushed
the
feat/RUN-3333_fixing-cpu-weight-test
branch
3 times, most recently
from
a145f05 to
58ec583
Compare
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
timcoding1988
force-pushed
the
feat/RUN-3333_fixing-cpu-weight-test
branch
2 times, most recently
from
e2f5490 to
5e6d490
Compare
openshift-merge-robot
added
the
needs-rebase
github-actions
bot
added
machine
kind/api-change
openshift-merge-robot
removed
the
needs-rebase
timcoding1988
force-pushed
the
feat/RUN-3333_fixing-cpu-weight-test
branch
from
7e0b30f to
9e9961e
Compare
Signed-off-by: Tim Zhou <[email protected]>
timcoding1988
force-pushed
the
feat/RUN-3333_fixing-cpu-weight-test
branch
from
9e9961e to
2c89069
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Luap99, timcoding1988 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
openshift-ci
bot
added
release-note-none
and removed
do-not-merge/release-note-label-needed
|
Sure, LGTM on my end |
|
/lgtm |
openshift-merge-bot
bot
merged commit 2e4418a
into
containers:main
86 of 89 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the
podman update container all options v2 tests. this is a change duo to CRUN changes : containers/crun#1767we will need support both new and old values using for cpu weight calculation.
Does this PR introduce a user-facing change?