Configurable GINKGOTIMEOUT in winmake.ps1
#26847
Merged
+4
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allows to override default timeout values for test runs. Signed-off-by: Arthur Sengileyev <[email protected]>
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: arixmkii, baude The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
/lgtm |
openshift-merge-bot
bot
merged commit 37776dd
into
containers:main
38 of 41 checks passed
Luap99
added a commit
to Luap99/libpod
that referenced
this pull request
Aug 19, 2025
The winmake target is critical for the machine task as this is used to actually run the ginkgo command line. PR containers#26847 modified that line will not actaully running the tests which means it is easy to break CI with this. Now the chnage of the PR was correct so it worked fine this time but for the future make sure we actually run the tests in such cases. Signed-off-by: Paul Holzinger <[email protected]>
Luap99
added a commit
to Luap99/libpod
that referenced
this pull request
Aug 19, 2025
The winmake target is critical for the machine task as this is used to actually run the ginkgo command line. PR containers#26847 modified that line will not actually running the tests which means it is easy to break CI with this. Now the chnage of the PR was correct so it worked fine this time but for the future make sure we actually run the tests in such cases. Signed-off-by: Paul Holzinger <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #26795
Allows to override default timeout values for test runs.
I used the same logic as in
podman/Makefile
Line 143 in 8674775
Does this PR introduce a user-facing change?