Allow artifact add to override org.opencontainers.image.title annotation

[rhatdan]

Does this PR introduce a user-facing change?

Users of podman artifact add can override the org.opencontainers.image.title annotation.

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: rhatdan
Once this PR has been reviewed and has the lgtm label, please assign giuseppe for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[rhatdan]

@Luap99 PTAL

[ninja-quokka]

An issue this introduces is when using podman artifact add --annotation [1] the annotation is added to each file/blob passed in the call.

So ./bin/podman artifact add --annotation=org.opencontainers.image.title=testname multitest README.md MAINTAINERS.md results in an artifact with two files with the image title testname

So we need to do something like block setting the org.opencontainers.image.title if multiple artifacts are being added in one call or maybe better yet fail if the artifact already has file/blob with the same image.title as this will cover the situation of adding a file/blob to an existing artifact with podman artifact --append

@baude WDYT

[1] https://docs.podman.io/en/v5.6.2/markdown/podman-artifact-add.1.html#annotation-annotation-value

[rhatdan]

The same issue exists if you do the same name multiple times.

./bin/podman artifact add --annotation=org.opencontainers.image.title=testname multitest README.md
./bin/podman artifact add --annotation=org.opencontainers.image.title=testname multitest Maintainers.md

So we can either check to see if the annotation is already defined, or just leave it to the users to deal with it. IE this is legal theoretically in the spec, so if users add it then they have to deal with it when the attempt to mount the object.

[Luap99]

looks reasonable, as we discussed in the community meeting we should generate an error if the same name is set for more than one file.

[Luap99]

that is not checking the right thing, you need to inspect the artifact you just created with podmanTest.InspectArtifact("foobar") and use that return value to check the annotation