Skip to content
This repository was archived by the owner on Feb 10, 2021. It is now read-only.

Improve packaging by using PBR #25

Merged
merged 1 commit into from
Jun 28, 2019
Merged

Conversation

4383
Copy link
Collaborator

@4383 4383 commented Mar 28, 2019

PBR (Python Build Reasonableness)[1].

Overview:

  • remove python code
  • introduce meta project configuration
  • allow pypi to display readme at markdown format
  • automatize semver management based on git tag name (example 1.0.0)
  • automatize changelog generate
  • automatize authors file generate

PBR allow to automatically manage your version bumping,
your changelog, your authors file and a lot of useful
features like this.

You just have to publish a git tag and pbr generate
a version number based on the git tag name (example: 1.0.0).

It also a good practice to use setup.cfg to centralize
project configuration:

  • project meta
  • wheel
  • etc...

This commit remove python code to maintain by transform it
into configuration.

If you choose to distribute this project with pypi these
changes introduce readme displayed at markdown format compatible
with pypi.

[1] https://docs.openstack.org/pbr/latest/

Signed-off-by: Hervé Beraud [email protected]

@4383
Copy link
Collaborator Author

4383 commented Mar 28, 2019

This is the first part of the pypi automation.

After that you need to create a travis-ci account to use it to deploy by git tag push on github

@4383
Copy link
Collaborator Author

4383 commented Apr 16, 2019

Do you have any updates about this?

@rhatdan rhatdan requested a review from jwhonce April 17, 2019 13:27
@rhatdan
Copy link
Member

rhatdan commented Apr 17, 2019

This looks fine to me, but I really don't know much about dealing with pypy.

@lsm5 @jwhonce @baude PTAL

@4383
Copy link
Collaborator Author

4383 commented Apr 17, 2019

@rhatdan ack

@4383
Copy link
Collaborator Author

4383 commented May 10, 2019

@lsm5 @jwhonce @baude please can you take a look?

Thanks.

@baude
Copy link
Member

baude commented May 28, 2019

it looks fine to me but i also know almost nothing about pypy process. @jwhonce ptal

@4383
Copy link
Collaborator Author

4383 commented May 28, 2019

You only need to create an account on pypi and on travis-ci and in a second time I'll submit another patch to automatically publish on pypi when you (and your team) will push a new git tag on this repo.

But before that I need to know the name of your pypi account or the owner name.

PBR (Python Build Reasonableness)[1].

Overview:
- remove python code
- introduce meta project configuration
- allow pypi to display readme at markdown format
- automatize semver management based on git tag name (example 1.0.0)
- automatize changelog generate
- automatize authors file generate

PBR allow to automatically manage your version bumping,
your changelog, your authors file and a lot of useful
features like this.

You just have to publish a git tag and pbr generate
a version number based on the git tag name (example: 1.0.0).

It also a good practice to use setup.cfg to centralize
project configuration:
- project meta
- wheel
- etc...

This commit remove python code to maintain by transform it
into configuration.

If you choose to distribute this project with pypi these
changes introduce readme displayed at markdown format compatible
with pypi.

[1] https://docs.openstack.org/pbr/latest/

Signed-off-by: Hervé Beraud <[email protected]>
@4383
Copy link
Collaborator Author

4383 commented Jun 13, 2019

rebased on latest master changes

@rhatdan
Copy link
Member

rhatdan commented Jun 14, 2019

@jwhonce PTAL

@rhatdan
Copy link
Member

rhatdan commented Jun 28, 2019

Ok I can go with this, but what is the version I need to specify for podman-python?

@rhatdan rhatdan merged commit 46c7464 into containers:master Jun 28, 2019
@4383
Copy link
Collaborator Author

4383 commented Jun 28, 2019

Ok I can go with this, but what is the version I need to specify for podman-python?

I think you can create a version 1.4.3:

$ git tag 1.4.3
$ git push --tags

We just need to explain how we manage version for python-podman related to libpodman versions or something like that... The workflow is the same than with your proposed changes #34 .

@rhatdan
Copy link
Member

rhatdan commented Jun 28, 2019

Right I did greate a tag v0.0.1 and pushed it but the travis update failed.
https://travis-ci.org/containers/python-podman/jobs/551830753

@4383
Copy link
Collaborator Author

4383 commented Jun 28, 2019

Right I did greate a tag v0.0.1 and pushed it but the travis update failed.
https://travis-ci.org/containers/python-podman/jobs/551830753

No it's ok... it's due to a weird behaviour of travis who try to publish the same package for all the supported python versions...
If 1 version (python 3.5 by example) already publish the other can't due to the fact that the version was already published on pypi...

@4383
Copy link
Collaborator Author

4383 commented Jun 28, 2019

oh sorry I'm wrong.... I need to inspect what's problem

@4383
Copy link
Collaborator Author

4383 commented Jun 28, 2019

Apparently a rst issue... I will take a look

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants