Upgrade to webpack 5

[Sibirius]

Summary

This PR upgrades webpack and related packages to version 5.

Description

The config changes needed are actually quite minimal:

• adjusted node.os: 'empty' to resolve.fallback.os: false as stated here https://webpack.js.org/migrate/5/#clean-up-configuration
• removed OccurrenceOrderPlugin as it's on by default: https://webpack.js.org/migrate/3/#occurrenceorderplugin-is-now-on-by-default

Motivation and Context

We are using the contentful-management library in a React app and recently upgraded our build system to use webpack 5. After this upgrade we were seeing runtime errors relating to enums from this library not being defined.

We were able to narrow down the issue to the minimization step of webpack. With minimize: false everything is working fine. So I decided to give upgrading to webpack 5 in this repo a try and now it works for us.

I was able to successfully run build and test locally. Please let me know if there's anything else needed from my side.

Checklist (check all before merging)

• Both unit and integration tests are passing
• There are no breaking changes
• Changes are reflected in the documentation

[marcolink]

Hi @Sibirius 👋
Thanks for your contributions 🙏
Would you be able to also remove babel-minify-webpack-plugin and its usage as it is deprecated and webpack handles minification itself already?

[Sibirius]

@marcolink
I removed it now. Was thinking about that as well but wanted to keep the changes minimal as I wasn't sure if there was some specific reason for keeping this one around.
Happy to clean up even more if you have some suggestions.

[marcolink]

@Sibirius this looks great 🎉

Do you know why it"s now also creating the LICENCE files in the dist folder? 🤔

BEFORE

AFTER

[Sibirius]

@marcolink
This is the default behaviour of webpack 5 as far as I understand.
I could add the CleanWebpackPlugin or a custom plugin as suggested here: webpack/webpack#12506

[marcolink]

@Sibirius

If you would be able to integrate CleanWebpackPlugin for that purpose, i'd be happy to merge this PR right away 🙏

[Sibirius]

@marcolink
I didn't manage to get the CleanWebpackPlugin to work properly. It was always deleting other build artifacts as well even when I specifically configured it not to. Also there are talks in the issues that it might become deprecated.
So I went with a simple custom plugin. Hope that works for you.

[Sibirius]

@marcolink
Is there anything blocking the PR that I can help with?

[mayakarabula]

@Sibirius
hey Sibirius, sorry for the delay, Marco went on vacation, and this PR got off our radar for a couple of days.
I will take a look at it now.

[mayakarabula]

@Sibirius
hey again, I have tried to use the package built by webpack 5, but it looks like the export pattern is different, it exports an object contentfulManagement instead of functions directly as before, so for example:

const contentful = require('./dist/contentful-management.node')
console.log({ contentful })

results in

{
  contentful: {
    contentfulManagement: Object [Module] {
      RestAdapter: [Getter],
      ScheduledActionReferenceFilters: [Getter],
...

but it should have root-level exports for RestAdapter, createClient, etc, because otherwise, that would be a breaking change.
I am not super familiar with webpack configurations but I was able to get root-level exports when modifying line 50 in webpack.config.js - commenting the library parameter

    // library: 'contentfulManagement',

{
  contentful: Object [Module] {
    RestAdapter: [Getter],
    ScheduledActionReferenceFilters: [Getter],
...

If this sounds reasonable (to remove library param) I would suggest making this change in PR or otherwise getting the root-level exports

[Sibirius]

Hey @mayakarabula 👋
Sorry, for the delay on my side this time, as I was on vacation last week.
The change definitely seems reasonable to me 👍

Should I just close this one, since it's now continued in #1921 ?

[mayakarabula]

@Sibirius
No worries! feel free to continue with this PR, I have created the other one to do the change myself but I think it's better to use this PR as it has all the conversation history

[Sibirius]

@mayakarabula
Great! I've merged your changes in here. Should be good to go then.

[mayakarabula]

thank you! I will merge it

[contentful-automation]

🎉 This PR is included in version 10.40.0 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀