Skip to content

feat: exports field #2556

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

feat: exports field #2556

wants to merge 3 commits into from

Conversation

itxch
Copy link

@itxch itxch commented Feb 22, 2025 •
edited
Loading

Summary

Add exports field to package.json.

Description

Add exports field to package.json, to improve esm compatibility with modern tooling / projects.

This will cause a conflict with #2472 - but it should be fine - as its just the exports field.

Motivation and Context

Checklist (check all before merging)

  • Both unit and integration tests are passing
  • There are no breaking changes
  • Changes are reflected in the documentation

@itxch itxch mentioned this pull request Feb 22, 2025
Closed
itxch
itxch commented Feb 22, 2025
View reviewed changes
Copy link
Author

@itxch itxch left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.

@itxch itxch mentioned this pull request Feb 25, 2025
Open
@axe312ger
Copy link
Collaborator

@itxch thank you on pushing for this. I included your comment into our refactoring PR -> #2472

We will merge and release this PR soon, so I am going to close your PR. Thanks for the contribution!!

@axe312ger axe312ger closed this Mar 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@itxch @axe312ger