Skip to content

show tool outputs during tool call #5858

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

uinstinct
Copy link
Contributor

@uinstinct uinstinct commented May 27, 2025

Description

Show tool call outputs along with tool call arguments. Previously MCP arguments were only shown and not the MCP responses.

Also:

  • Added a new icon for ToolCall.
  • Removed the older SimpleToolCallUI.tsx and added its capabilities in ToolCall.tsx

References:

Checklist

  • [] I've read the contributing guide
  • [] The relevant docs, if any, have been updated or created
  • [] The relevant tests, if any, have been updated or created

Screenshots

feat.mp4

Tests

image

uinstinct added 2 commits May 27, 2025 12:45
- ToolCallDiv/ToolCall has the same and extended abilities from SimpleToolCallUI
@uinstinct uinstinct requested a review from a team as a code owner May 27, 2025 07:24
@uinstinct uinstinct requested review from RomneyDa and removed request for a team May 27, 2025 07:24
Copy link

cubic-dev-ai bot commented May 27, 2025

Your cubic subscription is currently inactive. Please reactivate your subscription to receive AI reviews and use cubic.

@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label May 27, 2025
Copy link

netlify bot commented May 27, 2025

Deploy Preview for continuedev canceled.

Name Link
🔨 Latest commit c57e5db
🔍 Latest deploy log https://app.netlify.com/projects/continuedev/deploys/6837f8854e78300008e3e585

uinstinct added 2 commits May 27, 2025 15:59
- and data-testid s
Copy link
Collaborator

@RomneyDa RomneyDa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@uinstinct showing output would be great. Can we add it as a Context Item peek instead of with the args? At some point we had it as a context item peek like any normal context items and then regressed when the simple tool call UI was added. I'd like to keep the args separate. Thanks for adding tests

@github-project-automation github-project-automation bot moved this from Todo to In Progress in Issues and PRs May 28, 2025
@uinstinct
Copy link
Contributor Author

Sure. Have separated out the context items/output items into a different component. Currently the output items are shown when the show args button is clicked.

updated designs

image


image

@uinstinct uinstinct requested a review from RomneyDa May 29, 2025 06:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:L This PR changes 100-499 lines, ignoring generated files.
Projects
Status: In Progress
Development

Successfully merging this pull request may close these issues.

2 participants