refactor: ♻️ Refactor CodeBaseIndexer out of core

[chezsmithy]

Description

Refector CodeBaseIndexer out of core.ts in a way that it can be independently passed to tools which might need to perform reindexing. Not in #5564 we would now pass core (this.codeBaseIndexer) to the tools implementations rather than the the entire core object.

Checklist

• I've read the contributing guide
• The relevant docs, if any, have been updated or created
• The relevant tests, if any, have been updated or created

Screenshots

[ For visual changes, include screenshots. Screen recordings are particularly helpful, and appreciated! ]

Tests

I've manually tested the following in debug:

1. At startup Indexing starts and suceeds.
2. Force Reindex works.
3. Rebuild index works.
4. Pausing and resuming indexing work.
5. Files in the test project show up in the index confirmed by using @files to lookup test.js

I've added new tests for CodeBaseIndexer.ts to cover the changes.

[cubic-dev-ai]

Your cubic subscription is currently inactive. Please reactivate your subscription to receive AI reviews and use cubic.

[netlify]

✅ Deploy Preview for continuedev canceled.

Name	Link
🔨 Latest commit	c38fca4
🔍 Latest deploy log	https://app.netlify.com/projects/continuedev/deploys/6838faee2e562400080d8c51

[chezsmithy]

@Patrick-Erichsen related to #5564 I've performed a refactor of CodeBaseIndxer.ts and core.ts to refactor the indexing functions out of core. I'm going to note a few questions in a self review for you.

[chezsmithy]

@Patrick-Erichsen this is no longer used anywhere in core. I can't see anywhere else it is used as well. Note in CodeBaseIndexer I just created a self contained new instance of this class. I'm not sure if this was meant to be a singleton or it's used in some other way? If it's no longer used we can refactor it out of here, and remove the initalization from core.ts.

[Patrick-Erichsen]

Nice catch @chezsmithy - I think this is safe to remove and would be appreciated if you could do so.

cc @sestinj for a sanity check however.

[Patrick-Erichsen]

I just poked around, seems like we might use it in extensions/vscode/src/commands.ts?

    "continue.giveAutocompleteFeedback": async () => {
      const feedback = await vscode.window.showInputBox({
        ignoreFocusOut: true,
        prompt:
          "Please share what went wrong with the last completion. The details of the completion as well as this message will be sent to the Continue team in order to improve.",
      });
      if (feedback) {
        const client = await continueServerClientPromise;
        const completionsPath = getDevDataFilePath(
          "autocomplete",
          LOCAL_DEV_DATA_VERSION,
        );

        const lastLines = await readLastLines.read(completionsPath, 2);
        client.sendFeedback(feedback, lastLines);
      }
    },

[sestinj]

Ah we should just remove this

[chezsmithy]

@Patrick-Erichsen note this is no longer used anywhere in core. I've moved initalization into CodeBaseIndexer rather than relying on this instance. Should we just remove it?

[Patrick-Erichsen]

Yep, let's remove this one too, thanks for calling it out 👍

[chezsmithy]

@sestinj cc on this question along with the other.

[Patrick-Erichsen]

This is a great cleanup, will make the callTools logic we originally discussed less dependent on core and this is just a solid cleanup in general. Nice we we can remove the awkward codebaseIndexerResolve things.

Going to wait to merge until I double check with @sestinj on that one comment but otherwise good to go 🚀

[sestinj]

All good to go from me except I think we should just completely remove "continue.giveAutocompleteFeedback"

[sestinj]

all looks great. as we're removing the continueServerClient, let's take out the "continue.giveAutocompleteFeedback" command in VS Code