Skip to content

fix: use rules when alwaysApply is absent #6763

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: use rules when alwaysApply is absent #6763

wants to merge 1 commit into from
+3 −3

Conversation

uinstinct
Copy link
Contributor

@uinstinct uinstinct commented Jul 23, 2025 •
edited
Loading

Description

alwaysApply: undefined was not working because the rule file path is always absolute

  • use .includes instead of .startsWith to search for the .continue folder
  • update tests

resolves CON-2955

Checklist

  • [] I've read the contributing guide
  • [] The relevant docs, if any, have been updated or created
  • [] The relevant tests, if any, have been updated or created

Screen recording or screenshot

before.mp4
after.mp4

Tests

[ What tests were added or updated to ensure the changes work as expected? ]

@uinstinct uinstinct requested a review from a team as a code owner July 23, 2025 14:47
@uinstinct uinstinct requested review from tingwai and removed request for a team July 23, 2025 14:47
@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Jul 23, 2025
@uinstinct uinstinct mentioned this pull request Jul 24, 2025
Merged
@github-project-automation github-project-automation bot moved this from Todo to In Progress in Issues and PRs Jul 24, 2025
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jul 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tingwai tingwai tingwai approved these changes

Assignees
No one assigned
Labels
lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
Issues and PRs
Status: In Progress
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@uinstinct @tingwai