fix: catch hub org loading errors, fallback to local #6769
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:M
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
cubic analysis
2 issues found across 1 file • Review in cubic
React with 👍 or 👎 to teach cubic. You can also tag @cubic-dev-ai to give feedback, ask questions, or re-run the review.
| configLoadInterrupted, | ||
| }); | ||
|
|
||
| return { config, errors, configLoadInterrupted }; | ||
| if (injectErrors) { |
There was a problem hiding this comment.
Injected validation errors are added after listeners are notified, so listeners never receive them
Prompt for AI agents
Address the following comment on core/config/ConfigHandler.ts at line 500:
<comment>Injected validation errors are added after listeners are notified, so listeners never receive them</comment>
<file context>
@@ -454,22 +477,35 @@ export class ConfigHandler {
}
}
- const { config, errors, configLoadInterrupted } =
- await this.currentProfile.reloadConfig(this.additionalContextProviders);
+ const {
+ config,
+ errors = [],
+ configLoadInterrupted,
</file context>
| ...orgDescs.map((org) => this.getNonPersonalHubOrg(org)), | ||
| ]); | ||
| // TODO make try/catch more granular here, to catch specific org errors | ||
| return { orgs }; |
There was a problem hiding this comment.
Previously collected validation errors are silently dropped because the return statement omits the errors array
Prompt for AI agents
Address the following comment on core/config/ConfigHandler.ts at line 188:
<comment>Previously collected validation errors are silently dropped because the return statement omits the errors array</comment>
<file context>
@@ -161,28 +160,52 @@ export class ConfigHandler {
this.currentOrg = selectedOrg;
this.currentProfile = selectedOrg.currentProfile;
- await this.reloadConfig(reason);
+ await this.reloadConfig(reason, errors);
} catch (e) {
- if (e instanceof Error && e.message.includes("AbortError")) {
+ if (signal.aborted) {
return;
</file context>
Suggested change
| return { orgs }; | |
| return { orgs, errors }; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Catches hub org loading errors
Summary by cubic
Handled errors when loading organizations from Continue Hub by falling back to local assistants if Hub loading fails.