feat: show a yellow border when staging is active #6819
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uinstinct
changed the title
dosubot
bot
added
the
size:M
tingwai
requested changes
Jul 28, 2025
There was a problem hiding this comment.
I think we could make add the text "🚧 staging" (something along those lines) somewhere to replace the yellow line. It won't be immediately clear to a newcomer what the yellow means, especially since when vs code is loading the extension a blue line indicator is shown
Comment on lines
+71
to
+72
| "controlPlane/getEnvironment", | ||
| "controlPlane/getFreeTrialStatus", |
There was a problem hiding this comment.
Nit: move these 2 lines above getModelsAddOnUpgradeUrl line above to keep ordering consistent with other files and mostly alphabetical order
gui/src/components/Layout.tsx
Outdated
| "controlPlane/getEnvironment", | ||
| undefined, | ||
| ); | ||
| console.log("debug2 response was", response); |
|
How about this small yellow dot indicator? |
tingwai
requested changes
Jul 29, 2025
gui/src/components/Layout.tsx
Outdated
| @@ -236,6 +247,15 @@ const Layout = () => { | |||
| <LocalStorageProvider> | |||
| <AuthProvider> | |||
| <LayoutTopDiv> | |||
| {showStagingIndicator && ( | |||
| <div | |||
| title="running on staging" | |||
There was a problem hiding this comment.
Suggested change
| title="running on staging" | |
| title="Staging environment" |
gui/src/components/Layout.tsx
Outdated
| @@ -236,6 +247,15 @@ const Layout = () => { | |||
| <LocalStorageProvider> | |||
| <AuthProvider> | |||
| <LayoutTopDiv> | |||
| {showStagingIndicator && ( | |||
| <div | |||
There was a problem hiding this comment.
Let's change this to a span so there's a tooltip on hover
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
show a thin yellow border on the top of gui layout when staging is enabled.
resolves CON-2977
Checklist
Screen recording or screenshot
Tests
[ What tests were added or updated to ensure the changes work as expected? ]