Skip to content

Conversation

uinstinct
Copy link
Contributor

@uinstinct uinstinct commented Sep 26, 2025

Description

When auto-accept agent edit setting is turned on, automatically accept the edit tools including findandreplace, multiedit and editexistingfile.

resolves CON-3918

AI Code Review

  • Team members only: AI review runs automatically when PR is opened or marked ready for review
  • Team members can also trigger a review by commenting @continue-general-review or @continue-detailed-review

Checklist

  • [] I've read the contributing guide
  • [] The relevant docs, if any, have been updated or created
  • [] The relevant tests, if any, have been updated or created

Screen recording or screenshot

before.mp4
after.mp4

Tests

[ What tests were added or updated to ensure the changes work as expected? ]


Summary by cubic

Automatically accepts agent edit tool diffs when the auto-accept setting is enabled, skipping confirmation for Edit Existing File, Single Find & Replace, and Multi Edit calls. Addresses Linear CON-3918 to reduce friction in agent-led edits.

  • New Features
    • Checks ui.autoAcceptEditToolDiffs during tool call handling.
    • Auto-approves EditExistingFile, SingleFindAndReplace, and MultiEdit when enabled.

@uinstinct uinstinct requested a review from a team as a code owner September 26, 2025 10:02
@uinstinct uinstinct requested review from RomneyDa and removed request for a team September 26, 2025 10:02
@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Sep 26, 2025
Copy link
Collaborator

@RomneyDa RomneyDa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@uinstinct I agree YOLO mode should be expanded to include policies. With this implementation the policy behavior would conflict with the tool policy in the settings page. I think we could do this approach but only if we also show UI (maybe a tooltip/icon) to indicate that the tool policy is forced to automatic by the auto accept edits setting (and show it as automatic and disabled in the policies)

@github-project-automation github-project-automation bot moved this from Todo to In Progress in Issues and PRs Sep 26, 2025
@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. and removed size:S This PR changes 10-29 lines, ignoring generated files. labels Oct 6, 2025
@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. and removed size:XS This PR changes 0-9 lines, ignoring generated files. labels Oct 6, 2025
@uinstinct
Copy link
Contributor Author

@uinstinct I agree YOLO mode should be expanded to include policies. With this implementation the policy behavior would conflict with the tool policy in the settings page. I think we could do this approach but only if we also show UI (maybe a tooltip/icon) to indicate that the tool policy is forced to automatic by the auto accept edits setting (and show it as automatic and disabled in the policies)

added!

image

@uinstinct uinstinct requested a review from RomneyDa October 6, 2025 13:27
Copy link
Collaborator

@RomneyDa RomneyDa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@uinstinct just the console log otherwise lgtm!

EDIT pushed up tweaks for below

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Oct 6, 2025
@Patrick-Erichsen Patrick-Erichsen merged commit 22c6799 into continuedev:main Oct 6, 2025
51 of 54 checks passed
@github-project-automation github-project-automation bot moved this from In Progress to Done in Issues and PRs Oct 6, 2025
@github-actions github-actions bot locked and limited conversation to collaborators Oct 6, 2025
@uinstinct uinstinct deleted the auto-accept-edit branch October 7, 2025 04:08
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants