Feature/upgrade libraries #19
Conversation
src/Http/RequestFactory.php
Outdated
| @@ -29,7 +29,7 @@ public function getRawBody(): string | |||
|
|
|||
| private function getUri(): string | |||
| { | |||
| return $_SERVER['REQUEST_URI'] ?? '/'; | |||
| return $_SERVER['REQUEST_URI'] ?? '/'; // @phpstan-ignore return.type | |||
There was a problem hiding this comment.
What was the phpstan error here? Can we rather fix it?
There was a problem hiding this comment.
$_SERVER['REQUEST_URI'] (like everything in $_SERVER) is considered mixed. Fixable, like the others, at the cost of some readability. Can do.
There was a problem hiding this comment.
Yes, pls put there some check. Since it can be mixed... thanks
src/Http/RequestFactory.php
Outdated
| @@ -41,13 +41,15 @@ private function getHttpMethod(): string | |||
| } | |||
|
|
|||
| if ($method === 'POST' && isset($_SERVER['HTTP_X_HTTP_METHOD_OVERRIDE'])) { | |||
| $matched = preg_match('#^[A-Z]+\z#', $_SERVER['HTTP_X_HTTP_METHOD_OVERRIDE']); | |||
| $matched = preg_match('#^[A-Z]+\z#', $_SERVER['HTTP_X_HTTP_METHOD_OVERRIDE']); // @phpstan-ignore argument.type | |||
src/Http/RequestFactory.php
Outdated
|
|
||
| if ($matched === 1) { | ||
| $method = $_SERVER['HTTP_X_HTTP_METHOD_OVERRIDE']; | ||
| } | ||
| } | ||
|
|
||
| assert(is_string($method)); |
There was a problem hiding this comment.
Are we using asserts in this library at all? If not, what is the reason for it?
There was a problem hiding this comment.
No. Fixing the whole class makes this check useless, removed.
| @@ -30,7 +30,7 @@ public function create(string $rawRequest): RequestCollection | |||
| if (is_array($requestData)) { | |||
| foreach ($requestData as $oneRequestData) { | |||
| $collection->attach( | |||
| $this->createRequestFromRequestData($oneRequestData) | |||
| $this->createRequestFromRequestData($oneRequestData) // @phpstan-ignore argument.type | |||
There was a problem hiding this comment.
Phpstan is here to catch edge cases before there is a runtime error. We shouldn't really just ignore everything it throws at us.
- fix $_SERVER access to prove string, not just mixed - declare array content
jama-loma
force-pushed
the
feature/upgrade-libraries
branch
from
fa0d19f to
afacaa0
Compare
|
Updated to pass PhpStan's 2.0 new inspections
|
psr/http-message was upgraded to 2.0, so was phpstan. This change makes it possible to
requirethis library w/o conflicts in composer