Skip to content

Refactor dockerfile and entrypoint script #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 9, 2022
Merged

Refactor dockerfile and entrypoint script #41

merged 2 commits into from
Mar 9, 2022

Conversation

duhow
Copy link
Contributor

@duhow duhow commented Jan 19, 2022

For Dockerfile:

  • Use static version instead of latest
  • Perform actions in a single layer

For entrypoint:

  • Run jq with compact output
  • Fail if cannot call dispatch function

duhow added 2 commits January 19, 2022 17:11
@duhow
Refactor Dockerfile
e82dc5b 
- Use static version instead of latest
- Perform actions in a single layer
@duhow
Refactor entrypoint script
7e2b9b5 
- Run jq with compact output
- Fail if cannot call dispatch function
NotNils
NotNils reviewed Jan 28, 2022
View reviewed changes
entrypoint.sh
@@ -82,6 +82,11 @@ validate_args() {
fi
}

lets_wait() {
echo "Sleeping for ${wait_interval} seconds"
sleep $wait_interval
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs a fix I think. Compare it to line 127

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what exactly does need to be changed? code is in two sections, one has quotes, other does not, both work the same.

keithconvictional
keithconvictional approved these changes Mar 9, 2022
View reviewed changes
Copy link
Contributor

@keithconvictional keithconvictional left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@keithconvictional keithconvictional merged commit d2b75f3 into convictional:master Mar 9, 2022
This was referenced Mar 9, 2022
Merged
Merged
neilmayhew added a commit to neilmayhew/trigger-workflow-and-wait that referenced this pull request Mar 14, 2022
@neilmayhew
Restore lost changes from convictional#41
1ddab17 
* Combine layers in Docker image
* Use -c with jq when formatting client_payloads
* Refactor waiting into a common function

Originally authored by @duhow (David Girón <[email protected]>)
neilmayhew added a commit to neilmayhew/trigger-workflow-and-wait that referenced this pull request Mar 14, 2022
@neilmayhew
Restore lost changes from convictional#41
3a1ce05 
* Combine layers in Docker image
* Use -c with jq when formatting client_payloads
* Refactor waiting into a common function

Originally authored by @duhow (David Girón <[email protected]>)
neilmayhew added a commit to neilmayhew/trigger-workflow-and-wait that referenced this pull request Mar 14, 2022
@neilmayhew
Restore lost changes from convictional#41
0a95b94 
* Combine layers in Docker image
* Use -c with jq when formatting client_payloads
* Refactor waiting into a common function

Originally authored by @duhow (David Girón <[email protected]>)
neilmayhew added a commit to neilmayhew/trigger-workflow-and-wait that referenced this pull request Mar 14, 2022
@neilmayhew
Restore lost changes from convictional#41
243c096 
* Combine layers in Docker image
* Use -c with jq when formatting client_payloads
* Refactor waiting into a common function

Originally authored by @duhow (David Girón <[email protected]>)
karadikidd added a commit to karadikidd/trigger-workflow-and-wait that referenced this pull request Jun 9, 2025
@karadikidd @duhow
@neilmayhew @Danphillipz @kwavnet @grzegorz-faryna-mergermarket @bogaertg
chore: sync from main repo (#2)
f8830ad 
* Refactor dockerfile and entrypoint script

Re-add changes done in convictional#41

* Add GitHub Actions Workflow to build and selftest

* Use -r with jq when fetching run ids

* Remove unused input variable

* Make testing example in README use same parameter order as documentation

* Restore lost changes from convictional#41

* Combine layers in Docker image
* Use -c with jq when formatting client_payloads
* Refactor waiting into a common function

Originally authored by @duhow (David Girón <[email protected]>)

* bump README to 1.6.1

* Github actions rework (convictional#50)

* dummy change to test PR gha

* allow test to be run

* remove docker requirement, split out self-test

* remove last_workflow_interval

* Change action workflow to use project token (convictional#51)

* Change action workflow to use project token

* use personal access key

* Expose Conclusion as an action output (convictional#58)

Add conclusion output to yaml

* Update action.yml

* action: add option to post the workflow URL (convictional#57)

as a comment to a configurable comments API URL.
For instance when having very long running workflows called by the
action, it's hard for the user to see the actual pipeline and its
results.
For better tracebility and user expierence post the link to
the acquired workflow URL as a comment.

Typical setting would be to set it to
${{ github.event.pull_request.comments_url }} for pull requests.

As this may not be wanted by all users set the default to empty,
meaning no comments will be made

* entrypoint.sh: ignore Server Error responses (convictional#56)

as these are temporary problems it's safe to assume that
retrying it at a later point resolve the issue

Closes convictional#55

* The `set-output` command is deprecated (convictional#63)

The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

* escape wait_interval on line 87 (convictional#69)

* GA trigger test (convictional#71)

* Revert "GA trigger test (convictional#71)" (convictional#72)

This reverts commit 72beacf.

* Utilize the auto generated github token for comments (convictional#74)

* feat: use autogenerated github token for pull_request comments

* update secret token usage

Co-authored-by: Gaetan BOGAERT <[email protected]>

---------

Co-authored-by: duhow <[email protected]>
Co-authored-by: Neil Mayhew <[email protected]>
Co-authored-by: Rabih Salamey <[email protected]>
Co-authored-by: Daniel Phillips <[email protected]>
Co-authored-by: Konrad Weihmann <[email protected]>
Co-authored-by: Grzegorz Faryna <[email protected]>
Co-authored-by: b8fd286fcb585385 <[email protected]>
Co-authored-by: Gaetan BOGAERT <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
2 more reviewers

@NotNils NotNils NotNils left review comments

@keithconvictional keithconvictional keithconvictional approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@duhow @keithconvictional @NotNils