This repository was archived by the owner on Aug 26, 2024. It is now read-only.
Unique link keys #11
Open
Unique link keys #11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 26, 2018 16:27
- do no more use URL path as a key, but the complete URL - expand curies to the full URL to avoid collisions too Note that this changes the API, as the keys to retrieve the links of a document have changed.
fcayre
force-pushed
the
unique-link-keys
branch
from
ab57812 to
7e9e54c
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a proposal for #10. Note this changes the API, thus the suggested version bump.
I am really not sure about the curies expand, but we definitely need a unique key to avoid loosing links.
Comments much welcome.