Add a RootDirectory API
#54
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cgwalters
force-pushed
the
open-rooted
branch
2 times, most recently
from
61162a1 to
0049879
Compare
cgwalters
added a commit
to cgwalters/ostree-rs-ext
that referenced
this pull request
Jul 15, 2024
Use the API from coreos/cap-std-ext#54 to fix absolute symlinks for `/etc/ostree/auth.json`. cc bootc-dev/bootc#679 Signed-off-by: Colin Walters <[email protected]>
|
Usage in ostreedev/ostree-rs-ext#650 |
This was referenced Jul 15, 2024
jeckersb
reviewed
Jul 16, 2024
Right now cap-std uses `RESOLVE_BENEATH`, not `RESOLVE_IN_ROOT` which means absolute symlinks can't work. It's really handy to use cap-std where we can; I particularly like doing so in unit tests for example. However...we really do need to support absolute symlinks for many cases. Add a handy `RootDirectory` which exposes just a read-only subset of APIs - in particular we basically just want `open()` (and convenience wrappers like `read_to_string()` on this). For other writing cases right now, one needs to construct a regular `Dir`. Note that unlike the rest of cap-std, absolutely¹ no attempt is made to handle cases where `openat2` isn't accessible (non-Linux, cases where the kernel is too old, etc.) ¹ Pun not intended Signed-off-by: Colin Walters <[email protected]>
jeckersb
approved these changes
Jul 16, 2024
cgwalters
added a commit
to cgwalters/ostree-rs-ext
that referenced
this pull request
Jul 16, 2024
Use the API from coreos/cap-std-ext#54 to fix absolute symlinks for `/etc/ostree/auth.json`. cc bootc-dev/bootc#679 Signed-off-by: Colin Walters <[email protected]>
cgwalters
added a commit
to cgwalters/ostree-rs-ext
that referenced
this pull request
Aug 29, 2024
Use the API from coreos/cap-std-ext#54 to fix absolute symlinks for `/etc/ostree/auth.json`. cc bootc-dev/bootc#679 Signed-off-by: Colin Walters <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now cap-std uses
RESOLVE_BENEATH, notRESOLVE_IN_ROOTwhich means absolute symlinks can't work.It's really handy to use cap-std where we can; I particularly like doing so in unit tests for example.
However...we really do need to support absolute
symlinks for many cases. Add a handy
RootDirectorywhich exposes just a read-only subset of APIs - in particular we basically just wantopen()(and convenience wrappers likeread_to_string()on this).For other writing cases right now, one needs to construct a regular
Dir.Note that unlike the rest of cap-std, absolutely¹ no attempt is made to handle cases where
openat2isn't accessible (non-Linux, cases where the kernel is too old, etc.)¹ Pun not intended