Skip to content

Don't specify NextProtos so that we can take advantage of HTTP/2 #191

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 17, 2016

Conversation

aaronjwood
Copy link
Contributor

If we don't specify NextProtos HTTP/2 support will be enable when possible. See golang/go#14374 (comment) and golang/go@b5f0aff

@ghost
Copy link

ghost commented Aug 15, 2016

Can one of the admins verify this patch?

@aaronjwood
Copy link
Contributor Author

Actually, I don't see this TLSListeners method getting called anywhere. Should it be removed?

@aaronjwood
Copy link
Contributor Author

Going to close this as it looks like TLSListeners is dead code :)

@aaronjwood aaronjwood closed this Aug 15, 2016
@jonboulle
Copy link
Contributor

This isn't really dead code - it's an exported function that we happen to not use anywhere else internally in this repository ;-). I think this is still appropriate so feel free to re-open

@aaronjwood
Copy link
Contributor Author

Okay, reopening then :)

@aaronjwood aaronjwood reopened this Aug 15, 2016
@ghost
Copy link

ghost commented Aug 15, 2016

Can one of the admins verify this patch?

@jonboulle
Copy link
Contributor

ok to test

On 15 August 2016 at 18:07, Aaron Wood [email protected] wrote:

Okay, reopening then :)


You are receiving this because you commented.
Reply to this email directly, view it on GitHub
#191 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ACewN5Y5PGr4InmoKnY5fH50bvYcoeekks5qgI6vgaJpZM4Jke2y
.

@jonboulle
Copy link
Contributor

LGTM - any chance you can tweak your commit message though?
activation: remove setting of NextProtos from tls config or similar

@aaronjwood
Copy link
Contributor Author

Sure, just altered it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants