Fix EndTime nil pointer when persisting metrics #2259
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vishalbollu
changed the title
deliahu
reviewed
Jun 17, 2021
miguelvr
reviewed
Jun 18, 2021
miguelvr
approved these changes
Jun 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we used to get a snapshot of the batch metrics based on the job EndTime. The EndTime field would be nil if the job didn't complete due to an unhandled worker error. In such cases, controller would encounter a nil pointer error.
The controller has been updated to get a snapshot of the metrics in prometheus based on the current time rather than the EndTime so that even in situations where EndTime is nil, it tries to get the most accurate metrics.
checklist:
make testandmake lint