Skip to content

Write headers before setting status code #2323

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 8, 2021
Merged

Write headers before setting status code #2323

merged 1 commit into from
Jul 8, 2021

Conversation

vishalbollu
Copy link
Contributor

@vishalbollu vishalbollu commented Jul 8, 2021 •
edited
Loading

Writing headers after setting status code is a no-op. This is why even though we've set content-type application/json headers, the async-gateway doesn't respond with those headers.

checklist:

  • run make test and make lint
  • test manually (i.e. build/push all images, restart operator, and re-deploy APIs)

@vishalbollu vishalbollu requested a review from miguelvr July 8, 2021 02:19
@vishalbollu vishalbollu merged commit 456b6db into master Jul 8, 2021
@vishalbollu vishalbollu deleted the async-return-content-type-headers branch July 8, 2021 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deliahu deliahu deliahu approved these changes

@miguelvr miguelvr Awaiting requested review from miguelvr

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vishalbollu @deliahu