Skip to content

Fix kube_deployment_status_replicas_available metric by adding its deployment label back #2328

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 9, 2021
Merged

Fix kube_deployment_status_replicas_available metric by adding its deployment label back #2328

merged 3 commits into from
Jul 9, 2021

Conversation

RobertLucian
Copy link
Member

@RobertLucian RobertLucian commented Jul 9, 2021 •
edited
Loading

Required for the replica count panel for the async dashboard.

No need to modify prometheus.md as it was already modified.

checklist:

  • run make test and make lint
  • test manually (i.e. build/push all images, restart operator, and re-deploy APIs)

@RobertLucian RobertLucian added the AsyncAPI Something related to the AsyncAPI kind label Jul 9, 2021
@RobertLucian RobertLucian requested review from deliahu and miguelvr July 9, 2021 13:03
@RobertLucian RobertLucian merged commit 7cdbba2 into master Jul 9, 2021
@RobertLucian RobertLucian deleted the fix/async-replica-count branch July 9, 2021 19:19
miguelvr pushed a commit that referenced this pull request Jul 19, 2021
@RobertLucian
Fix kube_deployment_status_replicas_available metric by adding its de…
c6e130d 
…ployment label (#2328)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miguelvr miguelvr miguelvr approved these changes

@deliahu deliahu Awaiting requested review from deliahu

Assignees
No one assigned
Labels
AsyncAPI Something related to the AsyncAPI kind
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RobertLucian @miguelvr