Skip to content

Get user to confirm uninstall #313

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Aug 13, 2019
Merged

Get user to confirm uninstall #313

merged 4 commits into from
Aug 13, 2019

Conversation

1vn
Copy link
Contributor

@1vn 1vn commented Aug 12, 2019

Closes #269

Checklist:

  • Run make test and make lint
  • Test end to end manually (e.g. build/push all images, restart operator, and run cx refresh)
  • Update examples
  • Update documentation (add any new files to summary.md)
  • Merge to master
  • Cherry-pick into release branches if it's a bugfix
  • Check gitbook that docs look good and links function properly
  • Alert team if dev environment changed
  • Delete the branch once it's merged

@1vn 1vn merged commit 967fa25 into master Aug 13, 2019
@1vn 1vn deleted the prompt-uninstall branch August 13, 2019 01:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deliahu deliahu deliahu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add confirmation prompt for uninstall
2 participants
@1vn @deliahu