Cloudwatch metrics #322

vishalbollu · 2019-08-14T02:24:47Z

Closes #225 , Closes #296

Checklist:

Run make test and make lint
Test end to end manually (e.g. build/push all images, restart operator, and run cx refresh)
Update examples
Update documentation (add any new files to summary.md)
Merge to master
Cherry-pick into release branches if it's a bugfix
Check gitbook that docs look good and links function properly
Alert team if dev environment changed
Delete the branch once it's merged

cli/cmd/get.go

docs/apis/apis.md

go.sum

cli/cmd/get.go

pkg/lib/strings/stringify.go

pkg/operator/endpoints/metric_ops.go

pkg/operator/endpoints/metrics.go

pkg/operator/endpoints/metric_ops.go

pkg/operator/endpoints/metrics.go

pkg/workloads/cortex/lib/api_utils.py

pkg/workloads/cortex/lib/context.py

pkg/workloads/cortex/onnx_serve/api.py

pkg/workloads/cortex/tf_api/api.py

cli/cmd/get.go

pkg/operator/api/schema/metrics.go

pkg/operator/endpoints/shared.go

cli/cmd/get.go

pkg/operator/workloads/metrics.go

cli/cmd/get.go

pkg/operator/workloads/metrics.go

vishalbollu added 14 commits August 8, 2019 14:37

Round 1

f4503b0

Update #2

a0d82be

Merge branch 'master' into cloudwatch-metrics

2e42615

Refactor common code

d604414

Cleanup metrics.go

a0a8598

Remove unnecessary cloudwatch files

4257d7d

Refactor code and fix bug in classes

22d6a47

Cleanup examples

46c5bf4

More cleanup

1525630

Merge branch 'master' into cloudwatch-metrics

ca80585

Remove logger.info lines

d65225e

Reset cortex.yaml

8ed9d49

Reset cortex.yaml again

9119ade

Linting

bf74184

vishalbollu changed the title ~~[WIP] Cloudwatch metrics~~ Cloudwatch metrics Aug 14, 2019

vishalbollu requested a review from deliahu August 14, 2019 15:14

deliahu reviewed Aug 15, 2019

View reviewed changes

vishalbollu added 2 commits August 15, 2019 10:52

Respond to PR comments

9b24a4f

Merge branch 'master' into cloudwatch-metrics

cb05031

deliahu reviewed Aug 15, 2019

View reviewed changes

vishalbollu added 8 commits August 18, 2019 17:57

Merge branch 'master' into cloudwatch-metrics

65f75ec

Add realtime

862b5dc

Merge branch 'master' into cloudwatch-metrics

6ceca20

Cleanup round 1

3cca1ff

Add realtime metrics querying

7d72882

Cleanup 2

268e290

Merge branch 'master' into cloudwatch-metrics

0de825c

Fix linting

02b2760

deliahu reviewed Aug 20, 2019

View reviewed changes

pkg/operator/workloads/metrics.go Show resolved Hide resolved

pkg/operator/workloads/metrics.go Outdated Show resolved Hide resolved

vishalbollu added 3 commits August 20, 2019 11:28

Address PR comments

5a8b1ce

Merge branch 'master' into cloudwatch-metrics

7e8d424

Fix linting

b4c701c

deliahu reviewed Aug 20, 2019

View reviewed changes

cli/cmd/get.go Outdated Show resolved Hide resolved

pkg/operator/workloads/metrics.go Outdated Show resolved Hide resolved

vishalbollu and others added 6 commits August 20, 2019 13:54

Add custom error

e6baa02

Fix typo in errors.go

1bfadb1

Adjust error messages

147f155

Updated error message when key is missing

8243dab

Merge branch 'master' into cloudwatch-metrics

0a2efa9

Merge branch 'master' into cloudwatch-metrics

fe3abf4

deliahu approved these changes Aug 21, 2019

View reviewed changes

Merge branch 'master' into cloudwatch-metrics

64d4f0e

vishalbollu merged commit 3286501 into master Aug 21, 2019

vishalbollu deleted the cloudwatch-metrics branch August 21, 2019 14:27

Cloudwatch metrics #322

Cloudwatch metrics #322

Uh oh!

Conversation

vishalbollu commented Aug 14, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

vishalbollu commented Aug 14, 2019 •

edited

Loading