Skip to content

Add the name of the failed handler to error message #382

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Aug 27, 2019
Merged

Add the name of the failed handler to error message #382

merged 5 commits into from
Aug 27, 2019

Conversation

vishalbollu
Copy link
Contributor

@vishalbollu vishalbollu commented Aug 27, 2019 •
edited
Loading

Closes #292

Checklist:

  • Run make test and make lint
  • Test end to end manually (e.g. build/push all images, restart operator, and run cx refresh)
  • Update examples
  • Update documentation (add any new files to summary.md)
  • Merge to master
  • Cherry-pick into release branches if it's a bugfix
  • Check gitbook that docs look good and links function properly
  • Alert team if dev environment changed
  • Delete the branch once it's merged

@vishalbollu vishalbollu requested a review from deliahu August 27, 2019 00:29
deliahu
deliahu reviewed Aug 27, 2019
View reviewed changes
@deliahu deliahu merged commit 35a2756 into master Aug 27, 2019
@deliahu deliahu deleted the request-handler-error-message branch August 27, 2019 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deliahu deliahu deliahu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Have more granular errors from handlers
2 participants
@vishalbollu @deliahu