Stream from cloudwatch logs directly #447

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

vishalbollu merged 11 commits into master from stream-logs-from-cloudwatch

Sep 12, 2019

Contributor

vishalbollu commented Sep 11, 2019

Closes #

Checklist:

Run make test and make lint
Test end to end manually (e.g. build/push all images, restart operator, and run cx refresh)
Update examples
Update documentation (add any new files to summary.md)
Merge to master
Cherry-pick into release branches if it's a bugfix
Check gitbook that docs look good and links function properly
Alert team if dev environment changed
Delete the branch once it's merged

vishalbollu added 2 commits

September 11, 2019 01:24


          Stream from cloudwatch logs directly

276429c


          Polish #1

91802d1

vishalbollu requested a review from deliahu

September 11, 2019 14:16


          Polish #2

d701148

deliahu reviewed

View reviewed changes

manager/manifests/fluentd.yaml Outdated Show resolved Hide resolved

manager/manifests/fluentd.yaml Outdated Show resolved Hide resolved

pkg/operator/workloads/logs.go Outdated Show resolved Hide resolved

deliahu reviewed

View reviewed changes

pkg/operator/workloads/logs.go Outdated Show resolved Hide resolved

deliahu reviewed

View reviewed changes

pkg/operator/workloads/logs.go Outdated Show resolved Hide resolved

deliahu reviewed

View reviewed changes

pkg/operator/workloads/logs.go Outdated Show resolved Hide resolved

deliahu reviewed

View reviewed changes

pkg/operator/workloads/logs.go Outdated Show resolved Hide resolved

deliahu reviewed

View reviewed changes

pkg/operator/workloads/logs.go Outdated Show resolved Hide resolved

deliahu reviewed

View reviewed changes

pkg/operator/workloads/logs.go Outdated Show resolved Hide resolved

vishalbollu added 5 commits

September 11, 2019 20:07


          Revert back to generic logging endpoint

41b7b29


          Remove debug statements

a8ca374


          Respond to PR comments

fbb7bf4


          Readd changes

6430cb4


          Add new lines back to licensing

4fb25f7

deliahu reviewed

View reviewed changes

pkg/operator/workloads/logs.go Outdated Show resolved Hide resolved

pkg/operator/workloads/logs.go Show resolved Hide resolved

pkg/operator/workloads/logs.go Outdated Show resolved Hide resolved


          Address writePending logic

494e0a4

deliahu approved these changes

View reviewed changes

vishalbollu and others added 2 commits

September 12, 2019 15:13


          Tweak error message

0152c2e


          Merge branch 'master' into stream-logs-from-cloudwatch

2c56d49

vishalbollu merged commit 4b5f3e0 into master

vishalbollu deleted the stream-logs-from-cloudwatch branch

September 12, 2019 20:04

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet