Skip to content

Support "None" dims in model signatures #465

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 17, 2019
Merged

Support "None" dims in model signatures #465

merged 3 commits into from
Sep 17, 2019

Conversation

deliahu
Copy link
Member

@deliahu deliahu commented Sep 16, 2019 •
edited
Loading

Checklist:

  • Run make test and make lint
  • Test end to end manually (e.g. build/push all images, restart operator, and run cx refresh)
  • Merge to master
  • Delete the branch once it's merged

@deliahu deliahu requested a review from vishalbollu September 16, 2019 23:41
@deliahu deliahu merged commit 059739e into master Sep 17, 2019
@deliahu deliahu deleted the none-dims branch September 19, 2019 23:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@vishalbollu vishalbollu vishalbollu approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@deliahu @vishalbollu