Skip to content

Show correct URL upon failed HTTP request from CLI #504

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 8, 2019
Merged

Show correct URL upon failed HTTP request from CLI #504

merged 2 commits into from
Oct 8, 2019

Conversation

vishalbollu
Copy link
Contributor

@vishalbollu vishalbollu commented Oct 8, 2019 •
edited
Loading

Closes #

Checklist:

  • Run make test and make lint
  • Test end to end manually (e.g. build/push all images, restart operator, and run cx refresh)
  • Update examples
  • Update documentation (add any new files to summary.md)
  • Merge to master
  • Cherry-pick into release branches if it's a bugfix
  • Check gitbook that docs look good and links function properly
  • Alert team if dev environment changed
  • Delete the branch once it's merged

@vishalbollu vishalbollu requested a review from deliahu October 8, 2019 18:41
@vishalbollu vishalbollu merged commit fced493 into master Oct 8, 2019
@deliahu deliahu deleted the update-cli-error-message branch October 11, 2019 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deliahu deliahu deliahu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vishalbollu @deliahu