Ring with more than i.cfg.NumTokens tokens

[codesome]

While working on #1750, I came across a case where the ring with an existing entry might have more tokens than what we have defined in the config. Such a case is not being handled yet.

cortex/pkg/ring/lifecycler.go

Lines 465 to 472 in 08ddf88

	// We exist in the ring, so assume the ring is right and copy out tokens & state out of there.
	i.setState(ingesterDesc.State)
	tokens, _ := ringDesc.TokensFor(i.ID)
	i.setTokens(tokens)
	level.Info(util.Logger).Log("msg", "existing entry found in ring", "state", i.GetState(), "tokens", len(tokens))
	// we haven't modified the ring, don't try to store it.
	return nil, true, nil

[stale]

This issue has been automatically marked as stale because it has not had any activity in the past 30 days. It will be closed in 7 days if no further activity occurs. Thank you for your contributions.

[codesome]

Bump, to remove the stale mark.

If such a case is is fine (as described above), we can close this issue, else keep it open to be fixed.

[logston]

Hi @codesome, I wanted to give this one a go as I am a user of Cortex but have little knowledge of the code base. Hoping to dip my feet in with this PR. If you have the time, please let me know if my PR was off base, on target, etc. Many thanks.

[codesome]

The issue is very old. And I am not even sure if it is still relevant. Closing this issue since it's old and no one has reported issues with this.