Remove surplus sort of labels in Ingester

[bboreham]

This is not a documented feature of the remote write protocol; it happens to be the way Prometheus 2 works but Prometheus 1 didn't send labels sorted.

cortex/pkg/distributor/distributor.go

Lines 252 to 253 in f91f757

	if strings.Compare(lastLabelName, label.Name) >= 0 {
	return 0, fmt.Errorf("Labels not sorted")

If we decide Cortex has this requirement we should document it and remove the surplus Sort() here:

cortex/pkg/ingester/index/index.go

Line 143 in f91f757

sort.Sort(internedLabels)

[stale]

This issue has been automatically marked as stale because it has not had any activity in the past 60 days. It will be closed in 15 days if no further activity occurs. Thank you for your contributions.

[bboreham]

I don't think this should be closed.

[pstibrany]

Distributor now sorts labels, if they are not sorted (most of the time they are). #1964

[pstibrany]

This is not a documented feature of the remote write protocol; it happens to be the way Prometheus 2 works but Prometheus 1 didn't send labels sorted.

cortex/pkg/distributor/distributor.go

Lines 252 to 253 in f91f757

	if strings.Compare(lastLabelName, label.Name) >= 0 {
	return 0, fmt.Errorf("Labels not sorted")

Btw, this checked didn't work before (it never set lastLabelName to anything else other than ""), which is why I started to look at it.

[pstibrany]

All sorting after distributor can be removed. Code needs to be checked for such places.

[yeya24]

Closing this issue as chunk engine has been removed from Cortex.