Skip to content

Publish and test arm docker images for every PR #4733

Closed
@friedrich-at-adobe

Description

@friedrich-at-adobe

Is your feature request related to a problem? Please describe.
Many users are already trying to use cortex with ARM.

Describe the solution you'd like
For every PR we should run tests in ARM and Intel.

Describe alternatives you've considered
I don't think there is an alternative, we have to support natively what users are doing.

There is already some support in:

cortex/Makefile

Lines 52 to 59 in cd78607

push-multiarch-build-image:
@echo
# Build image for each platform separately... it tends to generate fewer errors.
$(SUDO) docker buildx build --platform linux/amd64 --build-arg=revision=$(GIT_REVISION) --build-arg=goproxyValue=$(GOPROXY_VALUE) build-image/
$(SUDO) docker buildx build --platform linux/arm64 --build-arg=revision=$(GIT_REVISION) --build-arg=goproxyValue=$(GOPROXY_VALUE) build-image/
# This command will run the same build as above, but it will reuse existing platform-specific images,
# put them together and push to registry.
$(SUDO) docker buildx build -o type=registry --platform linux/amd64,linux/arm64 --build-arg=revision=$(GIT_REVISION) --build-arg=goproxyValue=$(GOPROXY_VALUE) -t $(IMAGE_PREFIX)build-image:$(IMAGE_TAG) build-image/

Metadata

Metadata

Assignees

No one assigned

    Labels

    good first issueThese are great first issues. If you are looking for a place to start, start here!keepaliveSkipped by stale bot

    Type

    No type

    Projects

    No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions