Skip to content

Support enabled_tenants and disabled_tenants in store-gateway #5133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
friedrichg opened this issue Feb 8, 2023 · 5 comments · Fixed by #5638
Closed

Support enabled_tenants and disabled_tenants in store-gateway #5133

friedrichg opened this issue Feb 8, 2023 · 5 comments · Fixed by #5638

Comments

@friedrichg
Copy link
Member

friedrichg commented Feb 8, 2023

Is your feature request related to a problem? Please describe.
enabled_tenants and disabled_tenants in rulers, compactors and alertmanager is a nice feature to run different ruler and compactors and alertmanager for different tenants.
It should be possible to do the same in store-gateway

Describe the solution you'd like
It should be possible to define -store-gateway.enabled-tenants and -store-gateway.disabled-tenants to enable specific tenants in the store-gateway cluster

Describe alternatives you've considered
None, I think this one is consistent with the rest of the options.

Additional context
None

@johurul000
Copy link

@friedrichg Is it beginner friendly?

@moki1202
Copy link
Contributor

moki1202 commented Feb 26, 2023

@friedrichg I can give this a try!

@friedrichg
Copy link
Member Author

@moki1202 yes
@moki1202 sure, go ahead. Another thing you can do as a beginner is to review other PRs and give suggestions that have not been given.

@moki1202
Copy link
Contributor

@moki1202 yes @moki1202 sure, go ahead. Another thing you can do as a beginner is to review other PRs and give suggestions that have not been given.

I would love to! I'll have a look at some of the PRs.

@stale
Copy link

stale bot commented Jun 18, 2023

This issue has been automatically marked as stale because it has not had any activity in the past 60 days. It will be closed in 15 days if no further activity occurs. Thank you for your contributions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment