Skip to content

List rules API not honoring exclude_alerts flag #5989

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
sirianni opened this issue May 31, 2024 · 3 comments · Fixed by #6011
Closed

List rules API not honoring exclude_alerts flag #5989

sirianni opened this issue May 31, 2024 · 3 comments · Fixed by #6011
Assignees
@rapphil
Labels
component/rules Bits & bobs todo with rules and alerts: the ruler, config service etc. type/bug

Comments

@sirianni
Copy link

sirianni commented May 31, 2024 •
edited
Loading

Describe the bug
I am consuming the Cortex API implicitly via Amazon Managed Prometheus (AMP).

When I hit /api/v1/rules?exclude_alerts=true I still get the list of active alerts[] array in the response.

According to the prometheus docs, the exclude_alerts should omit this element.

Environment:
Amazon Managed Prometheus
@yeya24
Copy link
Contributor

yeya24 commented Jun 5, 2024

Hi @rajagopalanand @rapphil, can you help take a look?

@yeya24 yeya24 added the component/rules Bits & bobs todo with rules and alerts: the ruler, config service etc. label Jun 5, 2024
@rajagopalanand
Copy link
Contributor

This is a bug in Cortex that needs to get fixed

@rapphil
Copy link
Contributor

rapphil commented Jun 6, 2024

@yeya24 can you assign this issue to me?

rajagopalanand added a commit to rajagopalanand/rajagopalanand-cortex that referenced this issue Jun 12, 2024
@rajagopalanand
fix for cortexproject#5989
909ccb9 
Signed-off-by: Anand Rajagopal <[email protected]>
@rajagopalanand rajagopalanand mentioned this issue Jun 12, 2024
Merged
3 tasks
rajagopalanand added a commit to rajagopalanand/rajagopalanand-cortex that referenced this issue Jun 12, 2024
@rajagopalanand
fix for cortexproject#5989
d4dc41a 
Signed-off-by: Anand Rajagopal <[email protected]>
rajagopalanand added a commit to rajagopalanand/rajagopalanand-cortex that referenced this issue Jun 18, 2024
@rajagopalanand
fix for cortexproject#5989
81601e9 
Signed-off-by: Anand Rajagopal <[email protected]>
rajagopalanand added a commit to rajagopalanand/rajagopalanand-cortex that referenced this issue Jun 18, 2024
@rajagopalanand
fix for cortexproject#5989
dd197d4 
Signed-off-by: Anand Rajagopal <[email protected]>
rajagopalanand added a commit to rajagopalanand/rajagopalanand-cortex that referenced this issue Jun 18, 2024
@rajagopalanand
fix for cortexproject#5989
84bd9f0 
Signed-off-by: Anand Rajagopal <[email protected]>
rajagopalanand added a commit to rajagopalanand/rajagopalanand-cortex that referenced this issue Jun 18, 2024
@rajagopalanand
fix for cortexproject#5989
add416e 
Signed-off-by: Anand Rajagopal <[email protected]>
rajagopalanand added a commit to rajagopalanand/rajagopalanand-cortex that referenced this issue Jun 18, 2024
@rajagopalanand
fix for cortexproject#5989
cbc6585 
Signed-off-by: Anand Rajagopal <[email protected]>
rajagopalanand added a commit to rajagopalanand/rajagopalanand-cortex that referenced this issue Jun 19, 2024
@rajagopalanand
fix for cortexproject#5989
b6d743d 
Signed-off-by: Anand Rajagopal <[email protected]>
rajagopalanand added a commit to rajagopalanand/rajagopalanand-cortex that referenced this issue Jun 19, 2024
@rajagopalanand
fix for cortexproject#5989
ab03cc6 
Signed-off-by: Anand Rajagopal <[email protected]>
rajagopalanand added a commit to rajagopalanand/rajagopalanand-cortex that referenced this issue Jun 19, 2024
@rajagopalanand
fix for cortexproject#5989
8a65ab1 
Signed-off-by: Anand Rajagopal <[email protected]>
rajagopalanand added a commit to rajagopalanand/rajagopalanand-cortex that referenced this issue Jun 19, 2024
@rajagopalanand
fix for cortexproject#5989
fb24c95 
Signed-off-by: Anand Rajagopal <[email protected]>
rajagopalanand added a commit to rajagopalanand/rajagopalanand-cortex that referenced this issue Jun 19, 2024
@rajagopalanand
fix for cortexproject#5989
620215e 
Signed-off-by: Anand Rajagopal <[email protected]>
rajagopalanand added a commit to rajagopalanand/rajagopalanand-cortex that referenced this issue Jun 20, 2024
@rajagopalanand
fix for cortexproject#5989
776786a 
Signed-off-by: Anand Rajagopal <[email protected]>
rajagopalanand added a commit to rajagopalanand/rajagopalanand-cortex that referenced this issue Jun 20, 2024
@rajagopalanand
fix for cortexproject#5989
7974554 
Signed-off-by: Anand Rajagopal <[email protected]>
rajagopalanand added a commit to rajagopalanand/rajagopalanand-cortex that referenced this issue Jun 20, 2024
@rajagopalanand
fix for cortexproject#5989
4edff61 
Signed-off-by: Anand Rajagopal <[email protected]>
rajagopalanand added a commit to rajagopalanand/rajagopalanand-cortex that referenced this issue Jun 20, 2024
@rajagopalanand
fix for cortexproject#5989
9103987 
Signed-off-by: Anand Rajagopal <[email protected]>
rajagopalanand added a commit to rajagopalanand/rajagopalanand-cortex that referenced this issue Jun 20, 2024
@rajagopalanand
fix for cortexproject#5989
0c61cfb 
Signed-off-by: Anand Rajagopal <[email protected]>
rajagopalanand added a commit to rajagopalanand/rajagopalanand-cortex that referenced this issue Jun 20, 2024
@rajagopalanand
fix for cortexproject#5989
dffee76 
Signed-off-by: Anand Rajagopal <[email protected]>
rajagopalanand added a commit to rajagopalanand/rajagopalanand-cortex that referenced this issue Jun 20, 2024
@rajagopalanand
fix for cortexproject#5989
519ba00 
Signed-off-by: Anand Rajagopal <[email protected]>
rajagopalanand added a commit to rajagopalanand/rajagopalanand-cortex that referenced this issue Jun 20, 2024
@rajagopalanand
fix for cortexproject#5989
ecf2d95 
Signed-off-by: Anand Rajagopal <[email protected]>
rajagopalanand added a commit to rajagopalanand/rajagopalanand-cortex that referenced this issue Jun 20, 2024
@rajagopalanand
fix for cortexproject#5989
16b5c0d 
Signed-off-by: Anand Rajagopal <[email protected]>
rajagopalanand added a commit to rajagopalanand/rajagopalanand-cortex that referenced this issue Jul 30, 2024
@rajagopalanand
fix for cortexproject#5989
713b06b 
Signed-off-by: Anand Rajagopal <[email protected]>
rajagopalanand added a commit to rajagopalanand/rajagopalanand-cortex that referenced this issue Jul 30, 2024
@rajagopalanand
fix for cortexproject#5989
3771a51 
Signed-off-by: Anand Rajagopal <[email protected]>
rajagopalanand added a commit to rajagopalanand/rajagopalanand-cortex that referenced this issue Jul 30, 2024
@rajagopalanand
fix for cortexproject#5989
172eea5 
Signed-off-by: Anand Rajagopal <[email protected]>
rajagopalanand added a commit to rajagopalanand/rajagopalanand-cortex that referenced this issue Jul 30, 2024
@rajagopalanand
fix for cortexproject#5989
0cd075a 
Signed-off-by: Anand Rajagopal <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rapphil rapphil

Labels
component/rules Bits & bobs todo with rules and alerts: the ruler, config service etc. type/bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add support for exclude_alerts flag in ListRules API rajagopalanand/rajagopalanand-cortex
5 participants
@sirianni @rajagopalanand @friedrichg @rapphil @yeya24