-
Notifications
You must be signed in to change notification settings - Fork 832
Closed
Description
Describe the bug
When defining meta fetcher metrics in Cortex compactor, we keep the metric subsystem name as blocks_meta
.
cortex/pkg/compactor/compactor_metrics.go
Lines 77 to 81 in be90c4a
m.baseFetcherSyncs = promauto.With(reg).NewCounterVec(prometheus.CounterOpts{ | |
Subsystem: block.FetcherSubSys, | |
Name: "cortex_compactor_meta_base_syncs_total", | |
Help: "Total blocks metadata synchronization attempts by base Fetcher.", | |
}, nil) |
We should remove the subsystem as those compactor metrics have prefix of blocks_meta
. The expectation should be those metric have prefix cortex_compactor
. So instead of the metric name being blocks_meta_cortex_compactor_meta_base_syncs_total
, the correct metric name should be cortex_compactor_meta_base_syncs_total
.
