Skip to content

Include metric name, label name, number of entries and limit in cardinality errors. #1328

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 29, 2019

Conversation

tomwilkie
Copy link
Contributor

Fixes #1325

@tomwilkie tomwilkie force-pushed the 1325-cardinality-limit branch from 2154c7f to 0612ccf Compare April 10, 2019 17:27
Signed-off-by: Tom Wilkie <[email protected]>
Copy link
Contributor

@jtlisi jtlisi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, this is a great addition

@gouthamve gouthamve merged commit 0f86eb9 into cortexproject:master Apr 29, 2019
@gouthamve gouthamve deleted the 1325-cardinality-limit branch April 29, 2019 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CardinalityExceededError should say what the limit is and what metric exceeded it.
3 participants