Avoid duplicate label index writes by combining LabelEntryCacheKeys and LabelWriteEntries #1435
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not a big fan of schema having side effects; I've always considered the schemas to be deterministic. Perhaps having |
bboreham
force-pushed
the
optimise-label-entries
branch
from
d904d10 to
04cc9f2
Compare
bboreham
changed the title
|
Changed as you suggested |
|
I ran this up in our staging environment, and the rate of index writes after midnight halved. |
…nd LabelWriteEntries This avoids re-writing yesterday's labels when we write a chunk that spans the day boundary. Signed-off-by: Bryan Boreham <[email protected]>
bboreham
force-pushed
the
optimise-label-entries
branch
from
04cc9f2 to
3cccb54
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1428
Move the write dedupe cache lookup down to
schemaso the labels for each bucket can be omitted if they've already been done. This avoids re-writing yesterday's labels when we write a chunk that spans the day boundary.It's now calling the cache separately for each bucket, but I felt the loss of clarity wasn't worth optimising this.