Skip to content

Return a NopIterator when bigchunk is empty #1461

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 18, 2019
Merged

Return a NopIterator when bigchunk is empty #1461

merged 1 commit into from
Jun 18, 2019

Conversation

bboreham
Copy link
Contributor

This is an alternative to #1355
Fixes #1354 (although that is already marked as fixed)

@bboreham bboreham mentioned this pull request Jun 11, 2019
Closed
csmarchbanks
csmarchbanks approved these changes Jun 11, 2019
View reviewed changes
Copy link
Contributor

@csmarchbanks csmarchbanks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this method more than making a new type.

@gouthamve
Copy link
Contributor

👍

@bboreham bboreham merged commit 0224dc1 into master Jun 18, 2019
@bboreham bboreham deleted the nop-iterator branch June 18, 2019 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@csmarchbanks csmarchbanks csmarchbanks approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Panic in querier
3 participants
@bboreham @gouthamve @csmarchbanks