Skip to content

Leave Server module running until end of shutdown #1463

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 12, 2019
Merged

Leave Server module running until end of shutdown #1463

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
70da0e7
Leave Server module running until end of shutdown
bboreham Jun 12, 2019
473b333
Elide stop() function into its caller
bboreham Jun 12, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 3 additions & 8 deletions pkg/cortex/cortex.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -221,18 +221,13 @@ func (t *Cortex) Run() error {

// Stop gracefully stops a Cortex.
func (t *Cortex) Stop() error {
t.server.Shutdown()
t.stop(t.target)
return nil
}

func (t *Cortex) stop(m moduleName) {
t.stopModule(m)
deps := orderedDeps(m)
t.stopModule(t.target)
deps := orderedDeps(t.target)
// iterate over our deps in reverse order and call stopModule
for i := len(deps) - 1; i >= 0; i-- {
t.stopModule(deps[i])
}
return nil
}

func (t *Cortex) stopModule(m moduleName) {
Expand Down