Support custom endpoint for S3 #1476
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mizeng
force-pushed
the
suport_s3
branch
2 times, most recently
from
7926f89 to
d0ffe74
Compare
bboreham
approved these changes
Jun 26, 2019
| @@ -135,6 +136,9 @@ func (cfg *StorageConfig) RegisterFlags(f *flag.FlagSet) { | |||
|
|
|||
| f.Var(&cfg.S3, "s3.url", "S3 endpoint URL with escaped Key and Secret encoded. "+ | |||
| "If only region is specified as a host, proper endpoint will be deduced. Use inmemory:///<bucket-name> to use a mock in-memory implementation.") | |||
| f.BoolVar(&cfg.S3ForcePathStyle, "s3.force-path-style", false, "Set this to `true` to force the request to use path-style addressing "+ | |||
There was a problem hiding this comment.
this explanation is a bit long for here - maybe put it in docs/arguments.md ?
There was a problem hiding this comment.
updated. plz help review again.
Signed-off-by: mizeng <[email protected]>
|
could you help to merge this? I'm waiting for porting it back to Loki.. |
|
Needs another approval per our process |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature for grafana/loki#699, support custom endpoint which is using
Path Style URLof S3.